From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>,
qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Emanuele Giuseppe Esposito" <eesposit@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Akihiko Odaki" <akihiko.odaki@gmail.com>
Subject: Re: [RFC PATCH-for-7.0 v2] cocoa: run qemu_init in the main thread
Date: Thu, 17 Mar 2022 12:57:46 +0100 [thread overview]
Message-ID: <2f4d8e8f-163a-d6d5-1a06-3a47f8969026@redhat.com> (raw)
In-Reply-To: <20220316160300.85438-1-philippe.mathieu.daude@gmail.com>
Just one change to aid future reading of the code, possibly. Move this
line:
On 3/16/22 17:03, Philippe Mathieu-Daudé wrote:
> + qemu_event_init(&cbevent, false);
just before
+ cbowner = [[QemuCocoaPasteboardTypeOwner alloc] init];
i.e. the place where it was before the patch, in cocoa_display_init.
Paolo
next prev parent reply other threads:[~2022-03-17 12:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 16:03 [RFC PATCH-for-7.0 v2] cocoa: run qemu_init in the main thread Philippe Mathieu-Daudé
2022-03-16 16:22 ` Akihiko Odaki
2022-03-16 17:31 ` Paolo Bonzini
2022-03-16 19:29 ` Peter Maydell
2022-03-16 21:06 ` Peter Maydell
2022-03-17 11:51 ` Paolo Bonzini
2022-03-16 16:47 ` Akihiko Odaki
2022-03-17 11:57 ` Paolo Bonzini [this message]
2022-03-17 12:44 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f4d8e8f-163a-d6d5-1a06-3a47f8969026@redhat.com \
--to=pbonzini@redhat.com \
--cc=akihiko.odaki@gmail.com \
--cc=eesposit@redhat.com \
--cc=f4bug@amsat.org \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philippe.mathieu.daude@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).