From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1diKYx-0004H1-TI for qemu-devel@nongnu.org; Thu, 17 Aug 2017 09:10:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1diKYs-0006oc-71 for qemu-devel@nongnu.org; Thu, 17 Aug 2017 09:10:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38190) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1diKYs-0006ne-1k for qemu-devel@nongnu.org; Thu, 17 Aug 2017 09:10:10 -0400 References: <20170817092225.4264-1-david@redhat.com> <20170817092225.4264-10-david@redhat.com> <1cb3a142-be2d-920e-7b9e-f3ea3df0ad52@redhat.com> <42546fae-b442-2061-1b70-9b5603cab21d@redhat.com> <20170817150746.54ca6150.cohuck@redhat.com> From: David Hildenbrand Message-ID: <2f729af0-168b-25b8-621b-8a67c08bc6ce@redhat.com> Date: Thu, 17 Aug 2017 15:10:06 +0200 MIME-Version: 1.0 In-Reply-To: <20170817150746.54ca6150.cohuck@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v1 for-2.11 09/10] s390x/kvm: move KVM declarations and stubs to separate files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck , Thomas Huth Cc: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, borntraeger@de.ibm.com, Aurelien Jarno , rth@twiddle.net On 17.08.2017 15:07, Cornelia Huck wrote: > On Thu, 17 Aug 2017 15:06:10 +0200 > Thomas Huth wrote: >=20 >> On 17.08.2017 14:55, David Hildenbrand wrote: >>> On 17.08.2017 14:35, Thomas Huth wrote: =20 >>>> On 17.08.2017 13:40, Philippe Mathieu-Daud=C3=A9 wrote: =20 >>>>> On 08/17/2017 06:22 AM, David Hildenbrand wrote: =20 >> [...] >>>>>> feat-src =3D $(SRC_PATH)/target/$(TARGET_BASE_ARCH)/ >>>>>> diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h >>>>>> index 74d5b35..aeb730c 100644 >>>>>> --- a/target/s390x/cpu.h >>>>>> +++ b/target/s390x/cpu.h >>>>>> @@ -41,6 +41,7 @@ >>>>>> #include "exec/cpu-all.h" >>>>>> #include "fpu/softfloat.h" >>>>>> +#include "kvm_s390x.h" =20 >>>> >>>> Do we still need that? cpu.h should theoretically be independent fro= m >>>> kvm now, shouldn't it? And for the .c files, it's likely better to >>>> include kvm_s390x.h directly there if they require it. =20 >>> >>> It should work if: >>> >>> a) we include "sysemu/kvm.h" in hw/s390x/s390-virtio-ccw.c >>> b) we include "target/s390x/kvm_s390x.h" in hw/intc/s390_flic_kvm.c >>> c) we include "kvm_s390x.h" in "internal.h" >>> d) we drop the "KVMState" parameter from kvm_s390_get_memslot_count() >>> (separate patch) =20 >> >> Ok, that's rather a lot of changes already. Maybe that's rather >> something for a later patch instead, so I'm also fine if you keep in >> #include "kvm_s390x.h" in cpu.h here. >=20 > Yup, let's defer it. It's not like that is the last series that will > ever go in. >=20 Sorry guys, already creating patches :) --=20 Thanks, David