From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: WANG Rui <wangrui@loongson.cn>, Gao Song <gaosong@loongson.cn>
Cc: qemu-devel@nongnu.org, bibo mao <maobibo@loongson.cn>, qemu@hev.cc
Subject: Re: [PATCH v4 3/3] target/loongarch: Guard 64-bit-only insn translation with TRANS64 macro
Date: Fri, 18 Apr 2025 11:53:35 +0200 [thread overview]
Message-ID: <2f743d6c-b1fe-4abe-9779-8ca60d26e424@linaro.org> (raw)
In-Reply-To: <20250418082103.447780-4-wangrui@loongson.cn>
On 18/4/25 10:21, WANG Rui wrote:
> This patch replaces uses of the generic TRANS macro with TRANS64 for
> instructions that are only valid when 64-bit support is available.
>
> This improves correctness and avoids potential assertion failures or
> undefined behavior during translation on 32-bit-only configurations.
>
> Signed-off-by: WANG Rui <wangrui@loongson.cn>
> ---
> .../tcg/insn_trans/trans_atomic.c.inc | 36 +++++++++----------
> .../tcg/insn_trans/trans_extra.c.inc | 8 +++--
> .../tcg/insn_trans/trans_privileged.c.inc | 4 +--
> .../tcg/insn_trans/trans_shift.c.inc | 4 +--
> .../loongarch/tcg/insn_trans/trans_vec.c.inc | 16 ++++-----
> target/loongarch/translate.h | 4 +++
> 6 files changed, 40 insertions(+), 32 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2025-04-18 9:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 8:21 [PATCH v4 0/3] target/loongarch: Improve feature gating for instruction translation WANG Rui
2025-04-18 8:21 ` [PATCH v4 1/3] target/loongarch: Add CRC feature flag and use it to gate CRC instructions WANG Rui
2025-04-18 8:32 ` bibo mao
2025-04-18 9:54 ` Philippe Mathieu-Daudé
2025-04-18 8:21 ` [PATCH v4 2/3] target/loongarch: Guard BCEQZ/BCNEZ instructions with FP feature WANG Rui
2025-04-18 8:34 ` bibo mao
2025-04-18 8:21 ` [PATCH v4 3/3] target/loongarch: Guard 64-bit-only insn translation with TRANS64 macro WANG Rui
2025-04-18 8:45 ` bibo mao
2025-04-24 1:43 ` gaosong
2025-04-24 2:11 ` WANG Rui
2025-04-24 2:31 ` bibo mao
2025-04-24 2:59 ` WANG Rui
2025-04-24 4:10 ` bibo mao
2025-04-24 4:28 ` WANG Rui
2025-04-24 11:09 ` Jiaxun Yang
2025-04-18 9:53 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f743d6c-b1fe-4abe-9779-8ca60d26e424@linaro.org \
--to=philmd@linaro.org \
--cc=gaosong@loongson.cn \
--cc=maobibo@loongson.cn \
--cc=qemu-devel@nongnu.org \
--cc=qemu@hev.cc \
--cc=wangrui@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).