From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu@igor2.repo.hu, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH] tcg: Revert "tcg/optimize: Flush data at labels not TCG_OPF_BB_END"
Date: Wed, 4 Nov 2020 10:27:45 -0800 [thread overview]
Message-ID: <2f7460e0-e113-57ff-7816-3103feb40a8a@linaro.org> (raw)
In-Reply-To: <CAFEAcA82mtadB8r1kX1TG5Ft3qj0YPLXKebWUkXRG=dWew1SVg@mail.gmail.com>
On 11/4/20 10:12 AM, Peter Maydell wrote:
> On Tue, 3 Nov 2020 at 21:38, Richard Henderson
> <richard.henderson@linaro.org> wrote:
>>
>> This reverts commit cd0372c515c4732d8bd3777cdd995c139c7ed7ea.
>>
>> The patch is incorrect in that it retains copies between globals and
>> non-local temps, and non-local temps still die at the end of the BB.
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> I assume you're going to put this in a pullreq at some point
> before rc1?
Yep. I have one other bug fix as well.
r~
prev parent reply other threads:[~2020-11-04 18:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 21:38 [PATCH] tcg: Revert "tcg/optimize: Flush data at labels not TCG_OPF_BB_END" Richard Henderson
2020-11-04 18:12 ` Peter Maydell
2020-11-04 18:27 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f7460e0-e113-57ff-7816-3103feb40a8a@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu@igor2.repo.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).