From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DA02C2D0A3 for ; Wed, 4 Nov 2020 18:28:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 61BBD20759 for ; Wed, 4 Nov 2020 18:28:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nqKfK8VM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61BBD20759 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37624 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaNWQ-0004p4-53 for qemu-devel@archiver.kernel.org; Wed, 04 Nov 2020 13:28:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaNVg-0004NT-2d for qemu-devel@nongnu.org; Wed, 04 Nov 2020 13:27:52 -0500 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]:36457) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kaNVe-0008PN-HU for qemu-devel@nongnu.org; Wed, 04 Nov 2020 13:27:51 -0500 Received: by mail-pg1-x543.google.com with SMTP id z24so17301198pgk.3 for ; Wed, 04 Nov 2020 10:27:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mgFta/fqVLnKzSMnCM5ALE9qpfYYPGJlshjxx+9H5xw=; b=nqKfK8VMU/Q46daA0yJvUq7eNcHGxXx6yeWE8w474xIKWD3PneMd/gYPX4dMG8pwSK 01IocSwQtAkplRu80b8eI9znS3ESYHbldLL5eqVZT9WPA+rQttZn40UVLpx2OpVRHwSH YGgMFKIZA/jVp6r/Q8Vnlde4gqVS+mrxP+2vPQ7RsloQBp4//3VYSe/kk+i6QgZUE7A3 mlLXQti4D7Z8hPrH4BATaruSP1gM++NmYoYbKpERVAlIlTzsghVAEgLw6gyiOQvxfqGd KQJrFBsimEeW1wX4uwSBjnw1EqsT1+KOhmEg3BbplA7ZOH+3uaxndMf0ZbzVJzSVCpx2 e2rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mgFta/fqVLnKzSMnCM5ALE9qpfYYPGJlshjxx+9H5xw=; b=JxlrJKW6lF2Sjx+btGufhFliNiR3LikoB6eOZPyBTOdZjsXWVHk3mAnihLc1m+lWYU JK11YrFyT9ZywSv748qwriyatcOOjpyKG7cJRHVlIEnShzgGYpm4YJCeCtbQHbLK7zmH 7wSNuwxMAsYwqlBzXN28+5rnRn+YM+xUDZ+hqkpKGy5dcas2hAO/vY/umPey2BuSXglA At/gOoA9nD2k1r7+rqXZLpp+kobaGoiZbVRusafk2gaGxlVUYcnmJ0DZf0CEmQ/DkqZc uhOvZmvR2A6NRF6WIjdF8W7QEEmqX+UBTs2PZnk97RZT/7AGovRQPXU6qdKrQ3R7DFls 7fVA== X-Gm-Message-State: AOAM532RLlJT0//vEzTd98zxGhhETIn1tgHL9zdRSzYx/eVz3AZWOTV+ 4RJkdOpVZZwhd+IaOLyNYGFh/Q== X-Google-Smtp-Source: ABdhPJw0bd1v9GUBm/8LAcnyUfZnUkU6jIpT/bYZLWyCnWNkVPfFVXTwMtDVIu6o77p7axCVVgjlXQ== X-Received: by 2002:a63:cc08:: with SMTP id x8mr22338204pgf.229.1604514468412; Wed, 04 Nov 2020 10:27:48 -0800 (PST) Received: from [172.16.1.221] (76-14-210-194.or.wavecable.com. [76.14.210.194]) by smtp.gmail.com with ESMTPSA id e128sm2997199pfe.154.2020.11.04.10.27.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Nov 2020 10:27:47 -0800 (PST) Subject: Re: [PATCH] tcg: Revert "tcg/optimize: Flush data at labels not TCG_OPF_BB_END" To: Peter Maydell References: <20201103213852.253793-1-richard.henderson@linaro.org> From: Richard Henderson Message-ID: <2f7460e0-e113-57ff-7816-3103feb40a8a@linaro.org> Date: Wed, 4 Nov 2020 10:27:45 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::543; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x543.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu@igor2.repo.hu, QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/4/20 10:12 AM, Peter Maydell wrote: > On Tue, 3 Nov 2020 at 21:38, Richard Henderson > wrote: >> >> This reverts commit cd0372c515c4732d8bd3777cdd995c139c7ed7ea. >> >> The patch is incorrect in that it retains copies between globals and >> non-local temps, and non-local temps still die at the end of the BB. > > Reviewed-by: Peter Maydell > > I assume you're going to put this in a pullreq at some point > before rc1? Yep. I have one other bug fix as well. r~