From: Eric Blake <eblake@redhat.com>
To: Peter Lieven <pl@kamp.de>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, kwolf@redhat.com,
ashijeetacharya@gmail.com, jcody@redhat.com, mreitz@redhat.com,
armbru@redhat.com, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] block/nfs: fix naming of runtime opts
Date: Fri, 20 Jan 2017 09:36:39 -0600 [thread overview]
Message-ID: <2f7747d5-17dc-0d3b-143a-9e7bb22095ff@redhat.com> (raw)
In-Reply-To: <1484905570-10520-3-git-send-email-pl@kamp.de>
[-- Attachment #1: Type: text/plain, Size: 936 bytes --]
On 01/20/2017 03:46 AM, Peter Lieven wrote:
> commit 94d6a7a accidently left the naming of runtime opts and QAPI
> scheme inconsistent. As one consequence passing of parameters in the
> URI is broken. Sync the naming of the runtime opts to the QAPI
> scheme.
The commit message should explicitly mention that this is technically
backwards incompatible with the 2.8 release, but that the 2.8 release is
the only version that had the wrong naming and that release also had the
(just-fixed) bug of a crash during URI parsing.
>
> Fixes: 94d6a7a76e9df9919629428f6c598e2b97d9426c
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
> block/nfs.c | 30 +++++++++++++++---------------
> 1 file changed, 15 insertions(+), 15 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2017-01-20 15:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 9:46 [Qemu-devel] [PATCH 0/2] block/nfs: fix segfault and naming of runtime opts Peter Lieven
2017-01-20 9:46 ` [Qemu-devel] [PATCH 1/2] block/nfs: fix NULL pointer dereference in URI parsing Peter Lieven
2017-01-20 15:29 ` Eric Blake
2017-01-20 9:46 ` [Qemu-devel] [PATCH 2/2] block/nfs: fix naming of runtime opts Peter Lieven
2017-01-20 15:36 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f7747d5-17dc-0d3b-143a-9e7bb22095ff@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=ashijeetacharya@gmail.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).