From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 264DBFA3723 for ; Fri, 13 Sep 2024 07:37:33 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sp0rN-0002I2-Bo; Fri, 13 Sep 2024 03:36:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sp0rL-0002FD-Rx for qemu-devel@nongnu.org; Fri, 13 Sep 2024 03:36:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sp0rK-0001JJ-4A for qemu-devel@nongnu.org; Fri, 13 Sep 2024 03:36:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726213008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=WWf9Ud1t943/UcBE0ciBxW0uSbUDz2BhmhFyg6dw3zQ=; b=DQmfaaEJNj3Tkfmjc0p/UglwLg2KoKw0aJwgEf4Rp0k9ciQVXhlJ6+aR7ekyy8INpUB1zy Lt4iJVehcLvphu+Qe6Wm71ZQobuFywlmGng0fRBnFoxq9WbqoGTNOuxMnAbPd5iPM7v3HM D5IEhb37RjrsKag3P3CHQAjofQxbh5M= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-19-BMv_ZRgQOZCEj73AuYmmTQ-1; Fri, 13 Sep 2024 03:36:46 -0400 X-MC-Unique: BMv_ZRgQOZCEj73AuYmmTQ-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a870f3a65a0so138031766b.0 for ; Fri, 13 Sep 2024 00:36:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726213005; x=1726817805; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WWf9Ud1t943/UcBE0ciBxW0uSbUDz2BhmhFyg6dw3zQ=; b=wbt5HY9uywQENdPH6DN+mGfY0l+8qySALfUhGqKmPbmopPu7e34xD3/42Rd5+XX2vR T4nF+cfs45rn+8qAWDhwrz079hCLgSoc6YPGyq6YGXf299j2oi3nUHriyoxKnOI/cgTP Z+I5GMhE1vJNmZENokuGZrj4PhF6HX4EEtiRSFxU9w8fOY4tvXqPTQGA4xCRgrnQAXWN C5uQ9gltF8o/JahdoQUeIlyj52AwfKAAMKPKahAZu4rNWs2zQp9Yl2Un9dz92ov9s58r 1/XzOjxClcY/U3R7DLqF4PXI/8a6zcnH1e4xZI+tGcIUhEj2g5xpjuDdm0P1sspkCZjY GKGA== X-Forwarded-Encrypted: i=1; AJvYcCVnAY86puN5ytzp9xxjy+wjU8say5JdK/oTn5cBXOZwRv6/TdEyWoa+eIxyApUQW2z2IGTGiM+SvtsJ@nongnu.org X-Gm-Message-State: AOJu0Yxn2vDWVkju6sYXXsmJ8CI5ns5lsGAZq2BFpAMIxPh8PnbnRMff hx431t/VlNpQqmSkzp+JffRpkw1vaZEbXgXsjqIuTwImHg5hKFak2ROsN5HM1aZIfOnxcQGUugV GHzohkcLbaub8UZ7YvKFgGi8lWexoTc2zvxJsVb7g0LjhraMJggxdWnTV7SP50rw= X-Received: by 2002:a17:906:fd8b:b0:a80:f6a0:9c3c with SMTP id a640c23a62f3a-a902910de48mr509520866b.0.1726213005210; Fri, 13 Sep 2024 00:36:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGXetlVwdqLTUBbDJJTdyL3EzImKATG0R6nIKBtrBvS0MHNGl3MkpqBmt0eaOOHShCC9AqMtA== X-Received: by 2002:a17:906:fd8b:b0:a80:f6a0:9c3c with SMTP id a640c23a62f3a-a902910de48mr509518766b.0.1726213004712; Fri, 13 Sep 2024 00:36:44 -0700 (PDT) Received: from [192.168.0.6] (ip-109-43-178-122.web.vodafone.de. [109.43.178.122]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8d25d55709sm840527266b.210.2024.09.13.00.36.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Sep 2024 00:36:44 -0700 (PDT) Message-ID: <2f7acdd5-9d9d-442c-a19f-c8a5828ae02b@redhat.com> Date: Fri, 13 Sep 2024 09:36:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/5] hw/loongarch: Rename LOONGARCH_MACHINE with LOONGARCH_VIRT_MACHINE To: Bibo Mao , Song Gao , Peter Xu , Fabiano Rosas , Laurent Vivier Cc: Paolo Bonzini , qemu-devel@nongnu.org, =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= References: <20240508031110.2507477-1-maobibo@loongson.cn> <20240508031110.2507477-2-maobibo@loongson.cn> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20240508031110.2507477-2-maobibo@loongson.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.143, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 08/05/2024 05.11, Bibo Mao wrote: > On LoongArch system, there is only virt machine type now, name > LOONGARCH_MACHINE is confused, rename it with LOONGARCH_VIRT_MACHINE. > Machine name about Other real hw boards can be added in future. > > Signed-off-by: Bibo Mao > --- ... > diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c > index c0999878df..6619cb52a9 100644 > --- a/hw/loongarch/virt.c > +++ b/hw/loongarch/virt.c ... > @@ -1208,7 +1208,6 @@ static void loongarch_class_init(ObjectClass *oc, void *data) > MachineClass *mc = MACHINE_CLASS(oc); > HotplugHandlerClass *hc = HOTPLUG_HANDLER_CLASS(oc); > > - mc->desc = "Loongson-3A5000 LS7A1000 machine"; > mc->init = loongarch_init; > mc->default_ram_size = 1 * GiB; > mc->default_cpu_type = LOONGARCH_CPU_TYPE_NAME("la464"); Hi! I noticed that the machine now does not have any description anymore, which is kind of ugly when you list the available machines: $ ./qemu-system-loongarch64 -M help Supported machines are: none empty machine virt (null) (default) Could you please come up with a new mc->desc for the virt machine? Thanks, Thomas