From: Thomas Huth <thuth@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: hpoussin@reactos.org, qemu-ppc@nongnu.org,
Gerd Hoffmann <kraxel@redhat.com>,
david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 1/3] audio: Move arch_init audio code to hw/audio/soundhw.c
Date: Tue, 9 May 2017 07:49:20 +0200 [thread overview]
Message-ID: <2f7b9e2e-dca4-6ab4-26db-275ed6f60d6f@redhat.com> (raw)
In-Reply-To: <20170508205735.23444-2-ehabkost@redhat.com>
On 08.05.2017 22:57, Eduardo Habkost wrote:
> There's no reason to keep the soundhw table in arch_init.c. Move
> that code to a new hw/audio/soundhw.c file.
>
> While moving the code, trivial coding style issues were fixed.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Changes v2 -> v3:
> * Update hw/ppc/prep.c to include hw/audio/audio.h too
>
> Changes v1 -> v2:
> * Rebase to latest qemu.git master
> ---
> include/hw/audio/audio.h | 3 +
> include/sysemu/arch_init.h | 2 -
> arch_init.c | 124 -----------------------------------
> hw/audio/soundhw.c | 156 +++++++++++++++++++++++++++++++++++++++++++++
> hw/ppc/prep.c | 1 +
> vl.c | 1 +
> hw/audio/Makefile.objs | 2 +
> 7 files changed, 163 insertions(+), 126 deletions(-)
> create mode 100644 hw/audio/soundhw.c
Good idea!
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2017-05-09 5:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 20:57 [Qemu-devel] [PATCH v3 0/3] arch_init: Move soundhw code to hw/audio/soundhw.c Eduardo Habkost
2017-05-08 20:57 ` [Qemu-devel] [PATCH v3 1/3] audio: Move arch_init audio " Eduardo Habkost
2017-05-09 2:42 ` David Gibson
2017-05-09 5:49 ` Thomas Huth [this message]
2017-05-10 10:49 ` Philippe Mathieu-Daudé
2017-05-08 20:57 ` [Qemu-devel] [PATCH v3 2/3] audio: Rename audio_init() to soundhw_init() Eduardo Habkost
2017-05-09 2:43 ` David Gibson
2017-05-09 4:43 ` Hervé Poussineau
2017-05-08 20:57 ` [Qemu-devel] [PATCH v3 3/3] audio: Rename hw/audio/audio.h to hw/audio/soundhw.h Eduardo Habkost
2017-05-09 2:43 ` David Gibson
2017-05-09 4:40 ` Hervé Poussineau
2017-05-08 22:54 ` [Qemu-devel] [PATCH v3 0/3] arch_init: Move soundhw code to hw/audio/soundhw.c no-reply
2017-05-09 3:13 ` Eduardo Habkost
2017-05-16 18:54 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f7b9e2e-dca4-6ab4-26db-275ed6f60d6f@redhat.com \
--to=thuth@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=hpoussin@reactos.org \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).