From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10] block/qapi: Remove redundat NULL check to silence Coverity
Date: Mon, 31 Jul 2017 09:00:15 -0500 [thread overview]
Message-ID: <2f7e54a4-3a99-2506-a3ec-e9df6272a30c@redhat.com> (raw)
In-Reply-To: <0c81b100-89af-83ba-069c-88b962b8a472@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 548 bytes --]
On 07/31/2017 08:06 AM, Eric Blake wrote:
> On 07/31/2017 07:51 AM, Kevin Wolf wrote:
In the subject line, s/redundat/redundant/
>> When skipping implicit nodes in bdrv_block_device_info(), we know that
>> bs0 is always non-NULL; initially, because it's taken from a BdrvChild
>> and a BdrvChild never has a NULL bs, and after the first iteration
>> because implicit nodes always have a backing file.
>>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2017-07-31 14:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 12:51 [Qemu-devel] [PATCH for-2.10] block/qapi: Remove redundat NULL check to silence Coverity Kevin Wolf
2017-07-31 13:06 ` Eric Blake
2017-07-31 14:00 ` Eric Blake [this message]
2017-07-31 14:07 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
2017-07-31 14:38 ` [Qemu-devel] " Jeff Cody
2017-07-31 14:54 ` Philippe Mathieu-Daudé
2017-07-31 15:13 ` Kevin Wolf
2017-07-31 15:17 ` Jeff Cody
2017-07-31 15:30 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f7e54a4-3a99-2506-a3ec-e9df6272a30c@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).