* [Qemu-devel] [PATCH] qga: unset frozen state if no mount points are frozen
@ 2017-12-16 7:34 Chen Hanxiao
2018-01-05 1:53 ` Chen Hanxiao
0 siblings, 1 reply; 2+ messages in thread
From: Chen Hanxiao @ 2017-12-16 7:34 UTC (permalink / raw)
To: qemu-devel; +Cc: Chen Hanxiao, Michael Roth
From: Chen Hanxiao <chenhanxiao@gmail.com>
If we set mountpoints to qmp_guest_fsfreeze_freeze_list,
we may got nothing to freeze as all mountpoints are
not valid.
Call ga_unset_frozen in this senario.
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
---
qga/commands-posix.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index e809e382eb..9fd51f1d7a 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -1273,6 +1273,12 @@ int64_t qmp_guest_fsfreeze_freeze_list(bool has_mountpoints,
}
free_fs_mount_list(&mounts);
+ /* We may not issue any FIFREEZE here when had mountpoints.
+ * Just unset ga_state here and ready for the next call.
+ */
+ if (has_mountpoints && i == 0) {
+ ga_unset_frozen(ga_state);
+ }
return i;
error:
--
2.14.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] qga: unset frozen state if no mount points are frozen
2017-12-16 7:34 [Qemu-devel] [PATCH] qga: unset frozen state if no mount points are frozen Chen Hanxiao
@ 2018-01-05 1:53 ` Chen Hanxiao
0 siblings, 0 replies; 2+ messages in thread
From: Chen Hanxiao @ 2018-01-05 1:53 UTC (permalink / raw)
To: Chen Hanxiao; +Cc: qemu-devel, Michael Roth
At 2017-12-16 15:34:17, "Chen Hanxiao" <chen_han_xiao@126.com> wrote:
>From: Chen Hanxiao <chenhanxiao@gmail.com>
>
>If we set mountpoints to qmp_guest_fsfreeze_freeze_list,
>we may got nothing to freeze as all mountpoints are
>not valid.
>Call ga_unset_frozen in this senario.
>
>Cc: Michael Roth <mdroth@linux.vnet.ibm.com>
>Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
>---
> qga/commands-posix.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/qga/commands-posix.c b/qga/commands-posix.c
>index e809e382eb..9fd51f1d7a 100644
>--- a/qga/commands-posix.c
>+++ b/qga/commands-posix.c
>@@ -1273,6 +1273,12 @@ int64_t qmp_guest_fsfreeze_freeze_list(bool has_mountpoints,
> }
>
> free_fs_mount_list(&mounts);
>+ /* We may not issue any FIFREEZE here when had mountpoints.
>+ * Just unset ga_state here and ready for the next call.
>+ */
>+ if (has_mountpoints && i == 0) {
>+ ga_unset_frozen(ga_state);
>+ }
> return i;
>
> error:
>--
Hi,
Any comments?
Regards,
- Chen
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-05 2:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-16 7:34 [Qemu-devel] [PATCH] qga: unset frozen state if no mount points are frozen Chen Hanxiao
2018-01-05 1:53 ` Chen Hanxiao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).