From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Zhao Liu <zhao1.liu@intel.com>, Michael Tokarev <mjt@tls.msk.ru>,
Laurent Vivier <laurent@vivier.eu>
Cc: "Daniel P . Berrangé" <berrange@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
"David Hildenbrand" <david@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>
Subject: Re: [PATCH 5/7] backends/hostmem-epc: Get rid of qemu_open_old()
Date: Mon, 15 Jul 2024 11:45:36 +0200 [thread overview]
Message-ID: <2fba3e7e-b5f3-4129-9628-954b727a25c5@linaro.org> (raw)
In-Reply-To: <20240715082155.28771-6-zhao1.liu@intel.com>
On 15/7/24 10:21, Zhao Liu wrote:
> For qemu_open_old(), osdep.h said:
>
>> Don't introduce new usage of this function, prefer the following
>> qemu_open/qemu_create that take an "Error **errp".
>
> So replace qemu_open_old() with qemu_open().
>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
> backends/hostmem-epc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-07-15 9:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 8:21 [PATCH 0/7] trivial: Replace some qemu_open_old() with qemu_open() Zhao Liu
2024-07-15 8:21 ` [PATCH 1/7] hw/i386/sgx: Get rid of qemu_open_old() Zhao Liu
2024-07-15 8:21 ` [PATCH 2/7] hw/usb/host-libusb: " Zhao Liu
2024-07-15 9:44 ` Philippe Mathieu-Daudé
2024-07-15 8:21 ` [PATCH 3/7] hw/usb/u2f-passthru: " Zhao Liu
2024-07-15 9:44 ` Philippe Mathieu-Daudé
2024-07-15 8:21 ` [PATCH 4/7] hw/vfio/container: " Zhao Liu
2024-07-15 9:46 ` Philippe Mathieu-Daudé
2024-07-16 13:43 ` Cédric Le Goater
2024-07-15 8:21 ` [PATCH 5/7] backends/hostmem-epc: " Zhao Liu
2024-07-15 9:45 ` Philippe Mathieu-Daudé [this message]
2024-07-15 14:02 ` Igor Mammedov
2024-07-15 8:21 ` [PATCH 6/7] backends/iommufd: " Zhao Liu
2024-07-15 9:45 ` Philippe Mathieu-Daudé
2024-07-16 8:10 ` Yi Liu
2024-07-15 8:21 ` [PATCH 7/7] backends/rng-random: " Zhao Liu
2024-07-15 9:46 ` Philippe Mathieu-Daudé
2024-07-15 10:10 ` Zhao Liu
2024-07-15 11:07 ` Michael Tokarev
2024-07-15 12:44 ` Zhao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fba3e7e-b5f3-4129-9628-954b727a25c5@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=david@redhat.com \
--cc=eblake@redhat.com \
--cc=imammedo@redhat.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).