From: Eric Blake <eblake@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 06/14] crypto: Make errp the last parameter of functions
Date: Fri, 21 Apr 2017 09:35:33 -0500 [thread overview]
Message-ID: <2fc043ba-af58-a94c-246e-ebbc5bbdc6c7@redhat.com> (raw)
In-Reply-To: <20170421122710.15373-7-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 763 bytes --]
On 04/21/2017 07:27 AM, Fam Zheng wrote:
> Move opaque to 2nd instead of the 2nd to last, so that compilers help
> check with the convertion.
s/convertion/conversion/
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> block/crypto.c | 12 ++++++------
> crypto/block-luks.c | 21 +++++++++------------
> include/crypto/block.h | 12 ++++++------
> tests/test-crypto-block.c | 12 ++++++------
> 4 files changed, 27 insertions(+), 30 deletions(-)
>
crypto/block-qcow.c also refers to the changed the types, but does not
care about its parameters, so it looks like you got everything.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-04-21 14:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 12:26 [Qemu-devel] [PATCH 00/14] Trivial cleanups around error reporting Fam Zheng
2017-04-21 12:26 ` [Qemu-devel] [PATCH 01/14] socket: Make errp the last parameter of socket_connect Fam Zheng
2017-04-21 12:26 ` [Qemu-devel] [PATCH 02/14] socket: Make errp the last parameter of inet_connect_saddr Fam Zheng
2017-04-21 12:26 ` [Qemu-devel] [PATCH 03/14] socket: Make errp the last parameter of unix_connect_saddr Fam Zheng
2017-04-21 12:27 ` [Qemu-devel] [PATCH 04/14] socket: Make errp the last parameter of vsock_connect_saddr Fam Zheng
2017-04-21 12:27 ` [Qemu-devel] [PATCH 05/14] block: Make errp the last parameter of bdrv_img_create Fam Zheng
2017-04-21 12:27 ` [Qemu-devel] [PATCH 06/14] crypto: Make errp the last parameter of functions Fam Zheng
2017-04-21 14:35 ` Eric Blake [this message]
2017-04-24 8:28 ` Daniel P. Berrange
2017-04-24 8:43 ` Fam Zheng
2017-04-24 9:24 ` Markus Armbruster
2017-04-24 9:27 ` Daniel P. Berrange
2017-04-21 12:27 ` [Qemu-devel] [PATCH 07/14] mirror: Make errp the last parameter of mirror_start_job Fam Zheng
2017-04-21 12:27 ` [Qemu-devel] [PATCH 08/14] block: Make errp the last parameter of commit_active_start Fam Zheng
2017-04-21 12:27 ` [Qemu-devel] [PATCH 09/14] nfs: Make errp the last parameter of nfs_client_open Fam Zheng
2017-04-21 12:27 ` [Qemu-devel] [PATCH 10/14] fdc: Make errp the last parameter of fdctrl_connect_drives Fam Zheng
2017-04-21 12:27 ` [Qemu-devel] [PATCH 11/14] scsi: Make errp the last parameter of virtio_scsi_common_realize Fam Zheng
2017-04-21 12:27 ` [Qemu-devel] [PATCH 12/14] migration: Make errp the last parameter of local functions Fam Zheng
2017-04-21 12:27 ` [Qemu-devel] [PATCH 13/14] qga: Make errp the last parameter of qga_vss_fsfreeze Fam Zheng
2017-04-21 12:27 ` [Qemu-devel] [PATCH 14/14] error: Apply error_propagate_null.cocci again Fam Zheng
2017-04-21 14:45 ` [Qemu-devel] [PATCH 00/14] Trivial cleanups around error reporting Eric Blake
2017-04-21 14:57 ` Markus Armbruster
2017-04-24 7:20 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fc043ba-af58-a94c-246e-ebbc5bbdc6c7@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).