From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53788) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFcFt-0001qS-QC for qemu-devel@nongnu.org; Wed, 22 Jun 2016 03:07:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFcFs-00037j-Tz for qemu-devel@nongnu.org; Wed, 22 Jun 2016 03:07:21 -0400 Sender: Richard Henderson References: <1466528974-12183-1-git-send-email-peter.maydell@linaro.org> <1466528974-12183-3-git-send-email-peter.maydell@linaro.org> From: Richard Henderson Message-ID: <2fc3f7e3-fbd2-78cf-e9f7-bdeb7caa08ec@twiddle.net> Date: Wed, 22 Jun 2016 00:07:09 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Fw: [Qemu-arm] [PATCH v2 2/6] exec.c: Remove static allocation of sub_section of sub_page List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vijay Kilari , Peter Maydell Cc: Paolo Bonzini , patches@linaro.org, QEMU Developers , qemu-arm , "Kumar, Vijaya" On 06/21/2016 11:55 PM, Vijay Kilari wrote: >> > + uint16_t sub_section[]; > NIT: Comment that this variable should be last member of this > struct will be helpful. > No comment required. The compiler will error otherwise. r~