From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05D83C433F5 for ; Sat, 5 Mar 2022 07:12:58 +0000 (UTC) Received: from localhost ([::1]:57488 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nQOb2-00049S-T2 for qemu-devel@archiver.kernel.org; Sat, 05 Mar 2022 02:12:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQOZz-00037j-73 for qemu-devel@nongnu.org; Sat, 05 Mar 2022 02:11:51 -0500 Received: from szxga01-in.huawei.com ([45.249.212.187]:3466) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQOZx-0001x4-FS for qemu-devel@nongnu.org; Sat, 05 Mar 2022 02:11:50 -0500 Received: from dggpeml500026.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4K9bTc0GpXzdbMZ; Sat, 5 Mar 2022 15:10:28 +0800 (CST) Received: from dggpeml100016.china.huawei.com (7.185.36.216) by dggpeml500026.china.huawei.com (7.185.36.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Sat, 5 Mar 2022 15:11:47 +0800 Received: from dggpeml100016.china.huawei.com ([7.185.36.216]) by dggpeml100016.china.huawei.com ([7.185.36.216]) with mapi id 15.01.2308.021; Sat, 5 Mar 2022 15:11:47 +0800 To: Stefano Garzarella CC: "stefanha@redhat.com" , "mst@redhat.com" , "cohuck@redhat.com" , "pbonzini@redhat.com" , "Gonglei (Arei)" , Yechuan , Huangzhichao , "qemu-devel@nongnu.org" Subject: RE: [PATCH v2 06/10] vdpa-dev: implement the unrealize interface Thread-Topic: [PATCH v2 06/10] vdpa-dev: implement the unrealize interface Thread-Index: AQHYC5/Zjg1hZmXIMU+Qm0j03W3d6axptBuAgEb0/tA= Date: Sat, 5 Mar 2022 07:11:47 +0000 Message-ID: <2fc59a3bd2a04257b86fb13901d9c54c@huawei.com> References: <20220117124331.1642-1-longpeng2@huawei.com> <20220117124331.1642-7-longpeng2@huawei.com> <20220119113601.rrd3fhr7lkyvu6lb@steredhat> In-Reply-To: <20220119113601.rrd3fhr7lkyvu6lb@steredhat> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.148.223] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected Received-SPF: pass client-ip=45.249.212.187; envelope-from=longpeng2@huawei.com; helo=szxga01-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reply-to: "Longpeng (Mike, Cloud Infrastructure Service Product Dept.)" From: longpeng2--- via > -----Original Message----- > From: Stefano Garzarella [mailto:sgarzare@redhat.com] > Sent: Wednesday, January 19, 2022 7:36 PM > To: Longpeng (Mike, Cloud Infrastructure Service Product Dept.) > > Cc: stefanha@redhat.com; mst@redhat.com; cohuck@redhat.com; > pbonzini@redhat.com; Gonglei (Arei) ; Yechuan > ; Huangzhichao ; > qemu-devel@nongnu.org > Subject: Re: [PATCH v2 06/10] vdpa-dev: implement the unrealize interface >=20 > On Mon, Jan 17, 2022 at 08:43:27PM +0800, Longpeng(Mike) via wrote: > >From: Longpeng > > > >Implements the .unrealize interface. > > > >Signed-off-by: Longpeng > >--- > > hw/virtio/vdpa-dev.c | 24 +++++++++++++++++++++++- > > 1 file changed, 23 insertions(+), 1 deletion(-) > > > >diff --git a/hw/virtio/vdpa-dev.c b/hw/virtio/vdpa-dev.c > >index bd28cf7a15..e5691d02bb 100644 > >--- a/hw/virtio/vdpa-dev.c > >+++ b/hw/virtio/vdpa-dev.c > >@@ -132,9 +132,31 @@ out: > > s->vdpa_dev_fd =3D -1; > > } > > > >+static void vhost_vdpa_vdev_unrealize(VhostVdpaDevice *s) > >+{ > >+ VirtIODevice *vdev =3D VIRTIO_DEVICE(s); > >+ int i; > >+ > >+ for (i =3D 0; i < s->num_queues; i++) { > >+ virtio_delete_queue(s->virtqs[i]); > >+ } > >+ g_free(s->virtqs); > >+ virtio_cleanup(vdev); > >+ > >+ g_free(s->config); >=20 > Is there a particular reason for these steps in a separate function? >=20 > >+} > >+ > > static void vhost_vdpa_device_unrealize(DeviceState *dev) > > { > >- return; > >+ VirtIODevice *vdev =3D VIRTIO_DEVICE(dev); > >+ VhostVdpaDevice *s =3D VHOST_VDPA_DEVICE(vdev); > >+ > >+ virtio_set_status(vdev, 0); > >+ vhost_vdpa_vdev_unrealize(s); > >+ g_free(s->dev.vqs); > >+ vhost_dev_cleanup(&s->dev); > >+ qemu_close(s->vdpa_dev_fd); > >+ s->vdpa_dev_fd =3D -1; > > } >=20 > Maybe we can have all steps (in the reverse order of > vhost_vdpa_device_realize) in vhost_vdpa_device_unrealize(). >=20 Make sense. Will do. > Stefano