qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
	qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org
Subject: Re: [PATCH] target/arm: Fix incorrect aa64_tidcp1 feature check
Date: Wed, 24 Jan 2024 02:20:43 +1000	[thread overview]
Message-ID: <2fda5397-0fbf-4d07-8674-3ad7a1d8c209@linaro.org> (raw)
In-Reply-To: <20240123160333.958841-1-peter.maydell@linaro.org>

On 1/24/24 02:03, Peter Maydell wrote:
> A typo in the implementation of isar_feature_aa64_tidcp1() means we
> were checking the field in the wrong ID register, so we might have
> provided the feature on CPUs that don't have it and not provided
> it on CPUs that should have it. Correct this bug.
> 
> Cc:qemu-stable@nongnu.org
> Fixes: 9cd0c0dec97be9 "target/arm: Implement FEAT_TIDCP1"
> Resolves:https://gitlab.com/qemu-project/qemu/-/issues/2120
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
>   target/arm/cpu-features.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


      reply	other threads:[~2024-01-23 16:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-23 16:03 [PATCH] target/arm: Fix incorrect aa64_tidcp1 feature check Peter Maydell
2024-01-23 16:20 ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2fda5397-0fbf-4d07-8674-3ad7a1d8c209@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).