Re: [PATCH 6/7] s390x: Build IPLB for virtio-pci devices

[Thomas Huth <thuth@redhat.com>]

On 20/10/2025 18.20, jrossi@linux.ibm.com wrote:
> From: Jared Rossi <jrossi@linux.ibm.com>
> 
> Search for a corresponding S390PCIBusDevice and build an IPLB if a device has
> been indexed for boot but does not identify as a CCW device,
> 
> PCI devices are not yet included in boot probing (they must have a boot index).
> Per-device loadparm is not yet supported for PCI devices.

Could you add it? Something similar to what has been done in 
scsi_property_add_specifics() in hw/scsi/scsi-disk.c for the SCSI disks?

...
> @@ -346,7 +349,7 @@ static void s390_ipl_set_boot_menu(S390IPLState *ipl)
>   static CcwDevice *s390_get_ccw_device(DeviceState *dev_st, int *devtype)
>   {
>       CcwDevice *ccw_dev = NULL;
> -    int tmp_dt = CCW_DEVTYPE_NONE;
> +    int tmp_dt = S390_DEVTYPE_NONE;
>   
>       if (dev_st) {
>           VirtIONet *virtio_net_dev = (VirtIONet *)
> @@ -393,6 +396,31 @@ static CcwDevice *s390_get_ccw_device(DeviceState *dev_st, int *devtype)
>       return ccw_dev;
>   }
>   
> +#define PCI_DEVTYPE_VIRTIO       0x05

Is this for virtio-block only ? If so, I'd maybe rather name it 
PCI_DEVTYPE_VIRTIO_BLK or so. Or will this be used for virtio-scsi-pci etc., 
too?

  Thomas