From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/2] configure: Allow user to specify sphinx-build binary
Date: Tue, 4 Feb 2020 13:37:01 +0100 [thread overview]
Message-ID: <2ff980d6-bfa1-0db4-62cc-c10a3e0865e6@redhat.com> (raw)
In-Reply-To: <87d0au8wlh.fsf@dusky.pond.sub.org>
On 04/02/20 11:39, Markus Armbruster wrote:
> Peter Maydell <peter.maydell@linaro.org> writes:
>
>> Currently we insist on using 'sphinx-build' from the $PATH;
>> allow the user to specify the binary to use. This will be
>> more useful as we become pickier about the capabilities
>> we require (eg needing a Python 3 sphinx-build).
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> I went with the most common convention for specifying "here's
>> an executable", like --make=, --install=, --python=....
>>
>> The only odd one out for our current configure options seems to be
>> that we want --with-git=GIT, not --git=GIT. You could argue that
>> that's a better convention,
>
> It's the one Autoconf uses.
>
>> but it makes more sense to me to
>> stick with the convention we currently mostly have. (Perhaps
>> we should even change --with-git= to --git= ?)
>
> Paolo, any implications on the Meson conversion?
Nope, there will still be a handwritten configure script (and in the
beginning it will be pretty much the same as now; in due time, it will
handle command line parsing only).
Paolo
next prev parent reply other threads:[~2020-02-04 12:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 13:25 [PATCH 0/2] configure: Check that sphinx-build is using Python 3 Peter Maydell
2020-02-03 13:25 ` [PATCH 1/2] configure: Allow user to specify sphinx-build binary Peter Maydell
2020-02-03 18:08 ` Alex Bennée
2020-02-04 10:39 ` Markus Armbruster
2020-02-04 12:37 ` Paolo Bonzini [this message]
2020-02-04 13:53 ` Wainer dos Santos Moschetta
2020-02-03 13:25 ` [PATCH 2/2] configure: Check that sphinx-build is using Python 3 Peter Maydell
2020-02-03 18:09 ` Alex Bennée
2020-02-04 13:58 ` Wainer dos Santos Moschetta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ff980d6-bfa1-0db4-62cc-c10a3e0865e6@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).