From: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
To: qemu-devel@nongnu.org, Hanna Czenczek <hreitz@redhat.com>
Cc: "Hanna Czenczek" <hreitz@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Albert Esteve" <aesteve@redhat.com>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Alex Benné e" <alex.bennee@linaro.org>
Subject: Re: [PATCH] vhost-user: Fix protocol feature bit conflict
Date: Mon, 16 Oct 2023 11:45:08 +0300 [thread overview]
Message-ID: <2m60m.9e9wlnnm01vd@linaro.org> (raw)
In-Reply-To: <20231016083201.23736-1-hreitz@redhat.com>
On Mon, 16 Oct 2023 11:32, Hanna Czenczek <hreitz@redhat.com> wrote:
>diff --git a/include/hw/virtio/vhost-user.h
>b/include/hw/virtio/vhost-user.h
>index 9f9ddf878d..1d4121431b 100644
>--- a/include/hw/virtio/vhost-user.h
>+++ b/include/hw/virtio/vhost-user.h
>@@ -29,7 +29,8 @@ enum VhostUserProtocolFeature {
> VHOST_USER_PROTOCOL_F_INBAND_NOTIFICATIONS = 14,
> VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS = 15,
> VHOST_USER_PROTOCOL_F_STATUS = 16,
>- VHOST_USER_PROTOCOL_F_SHARED_OBJECT = 17,
>+ /* Feature 17 reserved for VHOST_USER_PROTOCOL_F_XEN_MMAP. */
>+ VHOST_USER_PROTOCOL_F_SHARED_OBJECT = 18,
> VHOST_USER_PROTOCOL_F_MAX
> };
May I ask, why not define VHOST_USER_PROTOCOL_F_XEN_MMAP as well instead
of a comment mention?
Otherwise:
Reviewed-by: Emmanouil Pitsidianakis <manos.pitsidianakis@linaro.org>
next prev parent reply other threads:[~2023-10-16 8:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 8:32 [PATCH] vhost-user: Fix protocol feature bit conflict Hanna Czenczek
2023-10-16 8:45 ` Manos Pitsidianakis [this message]
2023-10-16 10:32 ` Viresh Kumar
2023-10-16 11:40 ` Alex Bennée
2023-10-17 5:36 ` Viresh Kumar
2023-10-17 7:51 ` Hanna Czenczek
2023-10-17 7:53 ` Viresh Kumar
2023-10-17 8:14 ` Hanna Czenczek
2023-10-17 8:16 ` Viresh Kumar
2023-10-17 8:25 ` Albert Esteve
2023-10-17 10:56 ` Stefan Hajnoczi
2023-10-17 14:38 ` Albert Esteve
2023-10-17 14:46 ` Stefan Hajnoczi
2023-10-16 12:01 ` Manos Pitsidianakis
2023-10-16 10:40 ` Hanna Czenczek
2023-10-16 10:13 ` Stefano Garzarella
2023-10-16 14:03 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2m60m.9e9wlnnm01vd@linaro.org \
--to=manos.pitsidianakis@linaro.org \
--cc=aesteve@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=hreitz@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).