From: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, John Snow <jsnow@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>, Fam Zheng <fam@euphon.net>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>, Peter Lieven <pl@kamp.de>,
Jeff Cody <codyprime@gmail.com>,
open list:Block Jobs <qemu-block@nongnu.org>
Subject: Re: [RFC PATCH v2 02/78] block: add fallthrough pseudo-keyword
Date: Wed, 18 Oct 2023 08:50:22 +0300 [thread overview]
Message-ID: <2pncg.iakee0lfrnfs@linaro.org> (raw)
In-Reply-To: <7efwgbjschmbjc2fjzuvwphwtl5ltfjydkvslctr5tfh6g7mqb@x2hf2cgps2yb>
On Wed, 18 Oct 2023 01:11, Eric Blake <eblake@redhat.com> wrote:
>> static bool cluster_needs_new_alloc(BlockDriverState *bs, uint64_t
>> l2_entry)
>> {
>> switch (qcow2_get_cluster_type(bs, l2_entry)) {
>> case QCOW2_CLUSTER_NORMAL:
>> + fallthrough;
>> case QCOW2_CLUSTER_ZERO_ALLOC:
>
>Why is this one needed? It looks two case labels for the same code is
>okay; the fallthrough attribute is only needed once a case label is no
>lonter empty.
> ...
>These two also look spurious.
>
> ...
>but these three seem spurious.
Thanks for pointing it out, Eric. Indeed these are mistakes.
By the way, there's a newer version posted [0] because as you noticed I
accidentally left --function-context on git-format-patch and didn't
notice that some of them blew up in size.
Also, the consensus in v1 was to reject this patch series in general
[1].
[0]: <cover.1697186560.git.manos.pitsidianakis@linaro.org>
https://lore.kernel.org/qemu-devel/cover.1697186560.git.manos.pitsidianakis@linaro.org/
[1]:
<CAFEAcA_fLBe9CuWFYpeuejj8dcerhFtPNX+iVaVFvH4SXx1oAg@mail.gmail.com>
https://lore.kernel.org/qemu-devel/CAFEAcA_fLBe9CuWFYpeuejj8dcerhFtPNX+iVaVFvH4SXx1oAg@mail.gmail.com/
--
Manos
next prev parent reply other threads:[~2023-10-18 6:00 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 7:56 [RFC PATCH v2 00/78] Strict disable implicit fallthrough Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 01/78] include/qemu/compiler.h: replace QEMU_FALLTHROUGH with fallthrough Emmanouil Pitsidianakis
2023-10-17 22:00 ` Eric Blake
2023-10-18 10:32 ` Alex Bennée
[not found] ` <2q0zq.6gn2tubfhjrk@linaro.org>
[not found] ` <87sf689is8.fsf@linaro.org>
[not found] ` <CAFEAcA9DQ6oR3fNicuUpntfZ8QdSA8PqO5irRuzNrpkpXUJUCA@mail.gmail.com>
2023-10-19 12:42 ` Alex Bennée
2023-10-13 7:56 ` [RFC PATCH v2 02/78] block: add fallthrough pseudo-keyword Emmanouil Pitsidianakis
2023-10-17 22:11 ` Eric Blake
2023-10-18 5:50 ` Manos Pitsidianakis [this message]
2023-10-13 7:56 ` [RFC PATCH v2 03/78] fpu/softfloat: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 04/78] qapi/opts-visitor: " Emmanouil Pitsidianakis
2023-10-17 22:11 ` Eric Blake
2023-10-13 7:56 ` [RFC PATCH v2 05/78] qobject/json: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 06/78] tcg: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 07/78] hw/virtio/virtio-balloon.c: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 08/78] hw/block: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 09/78] hw/acpi/aml-build.c: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 10/78] hw/ide/atapi.c: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 11/78] hw/timer: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 12/78] hw/usb: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 13/78] hw/adc: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 14/78] util/error-report.c: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 15/78] accel/tcg: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 16/78] audio: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 17/78] ui/sdl2.c: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 18/78] ui/win32-kbd-hook.c: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 19/78] target/hppa: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 20/78] target/mips: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 21/78] target/sparc: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 22/78] target/ppc: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 23/78] target/arm: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 24/78] target/alpha: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 25/78] target/i386: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 26/78] target/s390x: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 27/78] target/riscv: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 28/78] target/avr: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 29/78] target/cris: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 30/78] target/nios2: " Emmanouil Pitsidianakis
2023-10-13 7:56 ` [RFC PATCH v2 31/78] target/xtensa: " Emmanouil Pitsidianakis
2023-10-13 8:01 ` Max Filippov
2023-10-13 7:56 ` [RFC PATCH v2 32/78] target/m68k: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 33/78] target/rx: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 34/78] target/tricore: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 35/78] target/sh4: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 36/78] target/openrisc: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 37/78] target/hexagon: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 38/78] system/rtc.c: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 39/78] hw/scsi: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 40/78] hw/sd/sdhci.c: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 41/78] linux-user: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 42/78] hw/i386: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 43/78] hw/misc: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 44/78] hw/m68k/mcf_intc.c: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 45/78] hw/dma: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 46/78] disas: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 47/78] contrib/rdmacm-mux: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 48/78] contrib/vhost-user-scsi: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 49/78] hw/arm: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 50/78] hw/audio: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 51/78] chardev: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 52/78] hw/char: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 53/78] nbd: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 54/78] hw/core: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 55/78] hw/display: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 56/78] hw/input: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 57/78] hw/net: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 58/78] hw/ppc: " Emmanouil Pitsidianakis
2023-10-13 8:32 ` Harsh Prateek Bora
2023-10-13 9:40 ` Cédric Le Goater
2023-10-13 7:57 ` [RFC PATCH v2 59/78] hw/intc: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 60/78] qga: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 61/78] semihosting: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 62/78] hw/gpio: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 63/78] hw/ipmi: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 64/78] hw/mips: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 65/78] hw/nvme: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 66/78] hw/nvram/eeprom_at24c.c: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 67/78] hw/pci-host/pnv_phb3.c: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 68/78] hw/pci: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 69/78] hw/rdma/rdma_backend.c: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 70/78] hw/rtc: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 71/78] hw/s390x: " Emmanouil Pitsidianakis
2023-10-13 8:03 ` David Hildenbrand
2023-10-13 7:57 ` [RFC PATCH v2 72/78] hw/ssi: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 73/78] hw/watchdog/wdt_diag288.c: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 74/78] hw/cxl/cxl-device-utils.c: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 75/78] migration: " Emmanouil Pitsidianakis
2023-10-13 8:55 ` Juan Quintela
2023-10-13 7:57 ` [RFC PATCH v2 76/78] qemu-img.c: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 77/78] tests/unit/test-char.c: " Emmanouil Pitsidianakis
2023-10-13 7:57 ` [RFC PATCH v2 78/78] meson.build: increase -Wimplicit-fallthrough to 5 Emmanouil Pitsidianakis
2023-10-17 21:52 ` [RFC PATCH v2 00/78] Strict disable implicit fallthrough Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2pncg.iakee0lfrnfs@linaro.org \
--to=manos.pitsidianakis@linaro.org \
--cc=codyprime@gmail.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=stefanha@redhat.com \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).