From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: CLEMENT MATHIEU--DRIF <clement.mathieu--drif@eviden.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"zhenzhong.duan@intel.com" <zhenzhong.duan@intel.com>,
"kevin.tian@intel.com" <kevin.tian@intel.com>,
"yi.l.liu@intel.com" <yi.l.liu@intel.com>,
"peterx@redhat.com" <peterx@redhat.com>
Subject: Re: [PATCH] intel_iommu: Take the bql before registering a new address space
Date: Tue, 15 Apr 2025 15:24:43 +0200 [thread overview]
Message-ID: <3000f78a-5842-46f0-9dc4-cb8180c38a39@redhat.com> (raw)
In-Reply-To: <20250415123330.GB270228@fedora>
On 4/15/25 14:33, Stefan Hajnoczi wrote:
> On Tue, Apr 15, 2025 at 03:11:00AM -0400, Michael S. Tsirkin wrote:
>> On Tue, Apr 15, 2025 at 06:18:08AM +0000, CLEMENT MATHIEU--DRIF wrote:
>>> Address space creation might end up being called without holding the
>>> bql as it is exposed through the IOMMU ops.
>>>
>>> Signed-off-by: Clement Mathieu--Drif <clement.mathieu--drif@eviden.com>
>>
>>
>> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
>>
>> Stefan, want to pick this one up, too?
>
> Not yet, it may need to wait until after the release:
> - Discussion is still ongoing.
> - Is this a regression in 10.0 or a long-standing issue?
> - Who is affected and what is the impact?
>
> There are still a few hours left before -rc4 is tagged. I will merge it
> if consensus is reached and the missing information becomes clear.
There are other thread-safety issues in the same code, so I'd prefer to
hold this patch and not hold the release for it. Even if it's a
regression, it can be fixed with a quick 10.0.1 in a couple weeks.
Paolo
next prev parent reply other threads:[~2025-04-15 13:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 6:18 [PATCH] intel_iommu: Take the bql before registering a new address space CLEMENT MATHIEU--DRIF
2025-04-15 6:53 ` Philippe Mathieu-Daudé
2025-04-15 7:28 ` CLEMENT MATHIEU--DRIF
2025-04-15 7:42 ` Michael S. Tsirkin
2025-04-15 8:03 ` Philippe Mathieu-Daudé
2025-04-15 8:36 ` Yi Liu
2025-04-15 6:55 ` Michael S. Tsirkin
2025-04-15 7:11 ` Michael S. Tsirkin
2025-04-15 12:33 ` Stefan Hajnoczi
2025-04-15 13:24 ` Paolo Bonzini [this message]
2025-04-15 14:03 ` Michael S. Tsirkin
2025-04-15 14:14 ` CLEMENT MATHIEU--DRIF
2025-04-15 14:31 ` Stefan Hajnoczi
2025-04-15 8:33 ` Yi Liu
2025-04-15 9:30 ` Paolo Bonzini
2025-04-15 11:49 ` Philippe Mathieu-Daudé
2025-04-15 11:52 ` Philippe Mathieu-Daudé
2025-04-15 11:50 ` CLEMENT MATHIEU--DRIF
2025-04-15 11:51 ` Paolo Bonzini
2025-04-15 11:55 ` Philippe Mathieu-Daudé
2025-04-15 12:59 ` Paolo Bonzini
2025-04-15 15:27 ` CLEMENT MATHIEU--DRIF
2025-04-15 13:08 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3000f78a-5842-46f0-9dc4-cb8180c38a39@redhat.com \
--to=pbonzini@redhat.com \
--cc=clement.mathieu--drif@eviden.com \
--cc=jasowang@redhat.com \
--cc=kevin.tian@intel.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=yi.l.liu@intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).