qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Moore <pmoore@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: coreyb@linux.vnet.ibm.com, qemu-devel@nongnu.org,
	Anthony Liguori <anthony@codemonkey.ws>,
	Eduardo Otubo <otubo@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] seccomp: remove unused syscalls - for 1.6
Date: Thu, 18 Jul 2013 15:39:14 -0400	[thread overview]
Message-ID: <3018245.dexT5oYG6l@sifl> (raw)
In-Reply-To: <51E819BB.30801@redhat.com>

On Thursday, July 18, 2013 06:37:15 PM Paolo Bonzini wrote:
> Il 18/07/2013 18:35, Eduardo Otubo ha scritto:
> > On 07/18/2013 01:28 PM, Anthony Liguori wrote:
> >> Eduardo Otubo <otubo@linux.vnet.ibm.com> writes:
> >>> Hello all,
> >> 
> >>> In this small patch series I basically:
> >> Cover letter should be marked [PATCH 0/2].  Otherwise it defeats
> >> filtering.
> >> 
> >> Would like to see a Reviewed-by from someone before applying this.
> > 
> > I'm running some tests with qemu && xen, I'll post a v3 by the end of
> > the day. I'll format the cover letter in the correct way next time.
> 
> I feel that, at some point, grep and code review must trump experiments...
> 
> Paul, how did you guys handle this in other projects?

To the best of my knowledge QEMU currently stands alone with its complexity 
and use of seccomp filtering.  There are other applications, but they are 
either of the syscall sandboxing type where the users define the filters, or 
the rigid, smaller, well defined filter type.  QEMU is both large and has a 
huge number of options which affect the syscalls used.

At some point it would be nice to develop a mechanism to do some static 
analysis on a binary and its associated libraries to come up with a worst case 
filter (worst case because you might not want all the syscalls that a library 
uses, e.g. glibc).  Unfortunately, we don't have such a tool the moment - it's 
hard enough generating correct filters with a nice architecture agnostic 
manner :)

On the plus side, I think libseccomp is very close to being pretty much 
feature complete (excluding new architectures that may pop up, at present we 
are only x86, x86_64, x32, and ARM) so I'll be able to start turning some 
effort towards better tools and patches for existing applications.

-- 
paul moore
security and virtualization @ redhat

  reply	other threads:[~2013-07-18 19:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-16 18:07 [Qemu-devel] seccomp: remove unused syscalls - for 1.6 Eduardo Otubo
2013-07-16 18:07 ` [Qemu-devel] [PATCHv2 1/2] seccomp: no need to check arch in syscall whitelist Eduardo Otubo
2013-07-16 18:07 ` [Qemu-devel] [PATCHv2 2/2] seccomp: removing unused syscalls from whitelist Eduardo Otubo
2013-07-18 16:28 ` [Qemu-devel] seccomp: remove unused syscalls - for 1.6 Anthony Liguori
2013-07-18 16:35   ` Eduardo Otubo
2013-07-18 16:37     ` Paolo Bonzini
2013-07-18 19:39       ` Paul Moore [this message]
2013-07-18 19:48         ` Peter Maydell
2013-07-18 20:05           ` Paul Moore
2013-07-18 21:31             ` Peter Maydell
2013-07-18 21:34               ` Paul Moore
  -- strict thread matches above, loose matches on Subject: below --
2013-07-15 17:29 Eduardo Otubo
2013-07-15 17:29 ` Eduardo Otubo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3018245.dexT5oYG6l@sifl \
    --to=pmoore@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=coreyb@linux.vnet.ibm.com \
    --cc=otubo@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).