From: Richard Henderson <richard.henderson@linaro.org>
To: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,
qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org
Subject: Re: [RFC PATCH 2/4] arm/tcg: add decodetree entry for DSB nXS variant
Date: Mon, 14 Oct 2024 09:30:07 -0700 [thread overview]
Message-ID: <301dc926-4b67-4ea9-8562-e93499fef3f2@linaro.org> (raw)
In-Reply-To: <20241014-arm-feat-xs-v1-2-42bb714d6b11@linaro.org>
On 10/14/24 03:48, Manos Pitsidianakis wrote:
> +static bool trans_DSB_nXS(DisasContext *ctx, arg_DSB_nXS *a)
> +{
> + tcg_gen_mb(TCG_BAR_SC | TCG_MO_ALL);
> + return true;
> +}
This is missing the feature test:
if (!dc_isar_feature(aa64_xs, ctx)) {
return false;
}
r~
next prev parent reply other threads:[~2024-10-14 16:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 10:48 [RFC PATCH 0/4] No-op support for Arm FEAT_XS, feedback needed Manos Pitsidianakis
2024-10-14 10:48 ` [RFC PATCH 1/4] arm: Add FEAT_XS's TLBI NXS variants Manos Pitsidianakis
2024-10-14 16:21 ` Richard Henderson
2024-10-14 10:48 ` [RFC PATCH 2/4] arm/tcg: add decodetree entry for DSB nXS variant Manos Pitsidianakis
2024-10-14 16:30 ` Richard Henderson [this message]
2024-10-14 10:48 ` [RFC PATCH 3/4] arm/tcg/cpu64: add FEAT_XS feat in max cpu Manos Pitsidianakis
2024-10-14 16:31 ` Richard Henderson
2024-10-14 16:32 ` Richard Henderson
2024-10-14 10:48 ` [RFC PATCH 4/4] tests/tcg/aarch64: add system test for FEAT_XS Manos Pitsidianakis
2024-10-14 16:33 ` Richard Henderson
2024-10-14 17:35 ` Gustavo Romero
2024-10-14 16:41 ` [RFC PATCH 0/4] No-op support for Arm FEAT_XS, feedback needed Peter Maydell
2024-10-14 17:32 ` Gustavo Romero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=301dc926-4b67-4ea9-8562-e93499fef3f2@linaro.org \
--to=richard.henderson@linaro.org \
--cc=manos.pitsidianakis@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).