From: Paolo Bonzini <pbonzini@redhat.com>
To: Olaf Hering <olaf@aepfle.de>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Richard Henderson <rth@twiddle.net>,
"open list:Overall" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v1] exec: handle NULL pointer in flatview_read_continue
Date: Thu, 9 Aug 2018 16:37:05 +0200 [thread overview]
Message-ID: <30203041-c944-1a12-d983-9735756dc334@redhat.com> (raw)
In-Reply-To: <20180809162403.32c53c50.olaf@aepfle.de>
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
On 09/08/2018 16:24, Olaf Hering wrote:
> Am Thu, 9 Aug 2018 16:14:03 +0200 schrieb Olaf Hering
> <olaf@aepfle.de>:
>
>> The codepaths behind qemu_ram_ptr_length can return NULL.
>
> While that might be a bug by itself, the question is why in that case
> no memset(buf, 0xff, l) is done?
If no RAM is allocated (i.e. xen_map_cache will return NULL), however,
the memory should not be registered as RAM with the memory API. So I
think the bug is in Xen code.
Paolo
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-08-09 14:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 14:14 [Qemu-devel] [PATCH v1] exec: handle NULL pointer in flatview_read_continue Olaf Hering
2018-08-09 14:24 ` Olaf Hering
2018-08-09 14:37 ` Paolo Bonzini [this message]
2018-08-09 14:38 ` Olaf Hering
2018-08-09 14:52 ` Olaf Hering
2018-08-09 14:52 ` Paolo Bonzini
2018-08-09 14:55 ` Olaf Hering
2018-08-09 15:03 ` Paolo Bonzini
2018-08-10 10:25 ` Paolo Bonzini
2018-08-10 10:32 ` Olaf Hering
2018-08-10 12:29 ` Paolo Bonzini
2018-08-13 20:07 ` Olaf Hering
2018-08-14 6:26 ` Paolo Bonzini
2018-08-15 4:22 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30203041-c944-1a12-d983-9735756dc334@redhat.com \
--to=pbonzini@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=olaf@aepfle.de \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).