From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/6] target/arm64: properly handle DBGVR RESS bits
Date: Thu, 8 Nov 2018 18:09:46 +0100 [thread overview]
Message-ID: <3027e46a-42b2-4c5c-eaec-ce9caa64ecc0@linaro.org> (raw)
In-Reply-To: <20181108163329.19940-2-alex.bennee@linaro.org>
On 11/8/18 5:33 PM, Alex Bennée wrote:
> - .bvr = addr
> + .bvr = sextract64(addr, 52, 53)
I think you meant sextract64(addr, 0, 53).
What you wrote *should* have asserted, since 52+53 > 64.
r~
next prev parent reply other threads:[~2018-11-08 17:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 16:33 [Qemu-devel] [PATCH v2 0/6] KVM Guest Debug fixes (plus TCG EL2 debug tweaks) Alex Bennée
2018-11-08 16:33 ` [Qemu-devel] [PATCH v2 1/6] target/arm64: properly handle DBGVR RESS bits Alex Bennée
2018-11-08 17:09 ` Richard Henderson [this message]
2018-11-08 17:30 ` Alex Bennée
2018-11-08 16:33 ` [Qemu-devel] [PATCH v2 2/6] target/arm64: hold BQL when calling do_interrupt() Alex Bennée
2018-11-08 17:11 ` Richard Henderson
2018-11-08 16:33 ` [Qemu-devel] [PATCH v2 3/6] target/arm64: kvm debug set target_el when passing exception to guest Alex Bennée
2018-11-08 17:13 ` Richard Henderson
2018-11-08 16:33 ` [Qemu-devel] [PATCH v2 4/6] tests/guest-debug: fix scoping of failcount Alex Bennée
2018-11-08 17:14 ` Richard Henderson
2018-11-08 16:33 ` [Qemu-devel] [PATCH v2 5/6] arm: use symbolic MDCR_TDE in arm_debug_target_el Alex Bennée
2018-11-08 17:15 ` Richard Henderson
2018-11-08 16:33 ` [Qemu-devel] [PATCH v2 6/6] arm: fix aa64_generate_debug_exceptions to work with EL2 Alex Bennée
2018-11-08 17:25 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3027e46a-42b2-4c5c-eaec-ce9caa64ecc0@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).