From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Vincent Palatin <vpalatin@chromium.org>
Subject: Re: [Qemu-devel] hax_enabled() cannot be called in vl.c
Date: Tue, 4 Dec 2018 16:08:04 +0100 [thread overview]
Message-ID: <302d4d66-e879-beaf-4f95-92b8eb80af97@redhat.com> (raw)
In-Reply-To: <CAFEAcA8rx-ZzHfb5ABcGBHOWDcDwxOejxp_SW9LLuOf1-_cxdg@mail.gmail.com>
On 2018-12-04 15:45, Peter Maydell wrote:
> In vl.c we do this:
>
> if (hax_enabled()) {
> hax_sync_vcpus();
> }
>
> But hax_enabled() varies depending on CONFIG_HAX: if that is
> not defined then it is "#define hax_enabled() (0)", otherwise
> it is a function. And CONFIG_HAX is a per-target configuration
> define, only set for i386-softmmu and x86_64-softmmu.
I guess we should add CONFIG_HAX to include/exec/poison.h, just like
CONFIG_KVM can already be found there...?
Thomas
prev parent reply other threads:[~2018-12-04 15:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 14:45 [Qemu-devel] hax_enabled() cannot be called in vl.c Peter Maydell
2018-12-04 14:48 ` Paolo Bonzini
2018-12-04 15:08 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=302d4d66-e879-beaf-4f95-92b8eb80af97@redhat.com \
--to=thuth@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).