From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5984DC5479D for ; Fri, 6 Jan 2023 23:05:04 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDvlC-00055s-I7; Fri, 06 Jan 2023 18:04:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDvlA-00050h-Df for qemu-devel@nongnu.org; Fri, 06 Jan 2023 18:04:24 -0500 Received: from sonic309-21.consmr.mail.gq1.yahoo.com ([98.137.65.147]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pDvl7-0004C8-Sb for qemu-devel@nongnu.org; Fri, 06 Jan 2023 18:04:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673046257; bh=5EDETl/Bn40ksYDdHxFQPm8HxH4mlDcmh7uTqfmAZxw=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=uUot1KD7m/rROeXRXcAneoVytEcn/YyvQzAOgceGEzlR5k3liW6unrbm3A686MBXXFJgkJae9qamIQpPVf/ZbpPhw1XIiG2aCA3YhZ9m53OgKMU15PfVBG5y8t2RHn3JnAy1bqj/Fz7d3ri5OKfPAeNWraQEiOaPbFV/kAAKLNdh/b0+F3VKrYc2yiS63riATrVqRxoSw0zWkQtKilHjfIhLMonWJd+bMDUASt7L95qJwm5cqIrQEHGGdtaqQeLH5NtgFZJVX4+VPhM+IvOA2PL/mTVWT/4RQIvLNoSNPXKpX6H7TwfTJv06JR9M+MPcNYXXxZAYiNWUKoBWk5Q9ww== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673046257; bh=H8pCqt53rijduXGA/ATbxaUuckY3oh3NtPO5R2CHj6a=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=rWOpOIPg20sdwrwQWuAaLDFreFKshWlhfOfGWduypNVPkV94j/o/m4wIRKiNi30MP3aH492/+3x6lY/wqtVzhvwwrGpGsqMerYJuiFw93tA1BjOXetVaM54UqRS95PDhNR99PqXznrgLvsnDWpDdBNlti8S7ozZ0Rr1KdV43F+ZVtUULpq7lGV1k+BjB+BPjVORO5urC88/12GC9R4TJwcaVfXe0DZQ9yaFUgzcdK0a9LkuYFOa/a8VrqZlvaatQin+lkmmrRxnmzpyc1CSIlrKbZQbA9xlj2j0KH3gW2RchBCzmrbL3SdDXsjf2QDhp/yHCOH1qGgmfzPg3AW57Xw== X-YMail-OSG: w5.iMUIVM1l0eqGZQfenJKq0f3WWOoVU1G_PwzmLYayjTCdr5p_EL6nBnjFJgqa rDA7tjOPnqDGyMB94mV.fxfplHns2lCUBZRAg8osRBZaM.WwdM7Jpd2Ss2YHoI1IzlfFKvkSy9K4 A4wvuHYlJQ73AyvAB_n7XKjVl1OevIpQ2Jh5NZfPhnwzPm_0pa6FiOxyTJ8AJ.jB6vChfIqZm.Qp O7vaX.ubl.X9Ses4q082Eg3okm1J9MbLtOmM2h_nCh9s_T2mupXc.4ujZXmpheVkpqQwc5vOM5RH hYzPObcAS_v9RyuDTDDP6V869VHrJ6JBuT2g430TxIYovuuYa51an7ridQK22eo.Cv5npxcSrUw3 t4aOq_rcExrMjreScMYx0BFY6ccJYcAvrPq_ZBOwhgbl4NNikE.LIVWleYqi1fTmRbePh2t7NflP rDIprbzCihTdFc6X6h8KOVSRgKsPLNGidtawWu315IfQYrWGuhDcWDxt4zRSGY8MaLUcpXZUWAgv Kjfpqv8DXkpotVssAulyhrZKXGwI9KKONjuFD0uQmsQhcZeAeKXeJhxrcRXYucQDiqjgctOw.NZh wrSLgVUJOeUTmHncgyi4tm7nxb2FEKA47ZhppgoDGFRJhy5463d5QWtxzh1larSaiexRTpLgY4WM PQ_AMwXD8fDggq.XlnjWSLGg4_IFChEKzg7YgRtqj0GA_i0ey8kHTglvAqUg1Wn2KU2JWfSvQTyc iYroyzWpfvItkGx2ZeH6_XXbVQpUDAqsP2BdSVnt4fJ.Ct7RKwH4Jq1K_iby9zjIj7ZJsYfhCdFW 2xsRWJyxKeebG3.QIgtJARqrFmxdIzJRk0wdoW1rNwz1WHKEiVsN.7dQpSgUHdpuwZ4YaefdlVvZ SXVzqQLOevHZjrJ_gFI873PK.JHKFyMWfUxkdfVQLol73f93DNkSbrl0ClCDXATsMgp5_BCxhfGK h_4w0916KfWFkOf5kGaddnM7V_bAttxjCBOz9vq2EDHsHU0jK6AP76Q7a9_2cR3E.xRGk9fXCCaB bXGzu3q2i748rbm3mwcWvPJicS5DKi.MInmquPmkYkvSYy7Zd7S9FrHKY0tqzvI1Xe.VjycytL80 JdrkkB8vAIX_DL0YcIbF4NnDIlL.phu5kO1j6_MOjG1nf7OWhSoesUyognQYge_u76YpQ7DJKcOo kMDI8SK8g5gpw_pAMMpafG8tod8yDCD6XjJ0YlzHDr7iicYthWcQSXdedOtf9ooBYZsJqNZw3v9A wgJu45w40Lo_0RdkXsL4L1FzOaHqwXZqcbC4aXuOs8NfrmhB_RpvVKsx0Lhev1nNdIQPKS32X7dJ NgiKhA5b3L0HsteXprIGKyLxlEd6mP5_nnkL2qgVF9qE.vshx0c1wKTKsH2aCbGu03c._oqPoTWG GrBS_UK7A_U2XDU63.fq4CbsF57b0jbJH44rbNwZSMWXh5ER.PCa0p3U6ErCCgAhhFeX7qE_4vas QcRM3ZdRkXEZDXU8.LEfUQWoxKJetCOQF6.o43qJQEy8iBaLH09jz7uCZnOtd_dOHakcAzcjLXV8 XzQQbMnf5pxEhdFi7n0.cHixRpESkdUGX5dPa2_ofEaP1qcKrXkKqH6zj3xrlBSpqzn5EwVW04eb 67avXN5m_RVI0FUJgls0aXxF1MD.fRBhu1Pkpm5U7MERwU00XJircEYOTIdqueXUdGtHr2YolXWO _CiiVuEpVSJPJZ.c6QtdXUH3dO._5kAQ5MIHPcYI3FY0FFxCVmNBoEGFJxsOhymy5uUwPOtTLQG5 vOJVOBFy.yCuvtyaCJQN6Uj.47AdTOZd22p0MMIlCDhw1anAeTPIivksbwTX5ri8DWgYjzi6prX_ xyAVQ3neeiCvUJdxvXnjgspq9SFj6hcQgnAE8X5kT7icqm9tUiordUmXgm6jL.lK1P9S0au2YAzE QVP1vSX4wK9IOwjRb1HkZyTTxEYdrmJVoT59Kf1NrXRRic8.Au8JAsflprYiPFuo.c2U4C.QwnBu fB94511G7U.deu.EI4asowZUUXhuGvxg.iznHm2NlxOzJOIoL70.9BworJTQiO1QOiKgFheTN.dZ dQCiNXbk4A6YcpGHPviTW_PfSj2lLn589dJ4w2Zvmpl_ceC5aCmKFiQ1Uc6dQpujyp5VZZDRFEvr fCP_ZZG4cxQuNzlTavIuLKnFwfVA5NbqyH4Arl9fvPCX1aqtMAfgZccXJQnYZ9iMeFE4YTaEkkPO YkZxbL8J7RGaOGNUGZuU- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.gq1.yahoo.com with HTTP; Fri, 6 Jan 2023 23:04:17 +0000 Received: by hermes--production-bf1-5458f64d4-s52fb (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 73550f2f3ad1d326fe382ae3bf119149; Fri, 06 Jan 2023 23:04:16 +0000 (UTC) Message-ID: <30337c62-a938-61c8-3ae5-092dbccf6302@aol.com> Date: Fri, 6 Jan 2023 18:04:13 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE From: Chuck Zmudzinski To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Bernhard Beschow , qemu-devel@nongnu.org, Markus Armbruster Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , Thomas Huth References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-7-shentey@gmail.com> <1c2e0780-e5fb-1321-0d84-b0591db9fec7@linaro.org> <6a1a6ed8-568d-c08b-91a7-1093a2b25929@linaro.org> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Received-SPF: pass client-ip=98.137.65.147; envelope-from=brchuckz@aim.com; helo=sonic309-21.consmr.mail.gq1.yahoo.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-2.939, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 1/6/23 2:08 PM, Chuck Zmudzinski wrote: > On 1/6/23 7:25 AM, Philippe Mathieu-Daudé wrote: >> On 6/1/23 12:57, Bernhard Beschow wrote: >>> >>> >>> Am 4. Januar 2023 15:35:33 UTC schrieb "Philippe Mathieu-Daudé" : >>>> +Markus/Thomas >>>> >>>> On 4/1/23 15:44, Bernhard Beschow wrote: >>>>> During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of >>>>> TYPE_PIIX3_DEVICE. Remove this redundancy. >>>>> >>>>> Signed-off-by: Bernhard Beschow >>>>> --- >>>>> hw/i386/pc_piix.c | 4 +--- >>>>> hw/isa/piix.c | 20 -------------------- >>>>> include/hw/southbridge/piix.h | 1 - >>>>> 3 files changed, 1 insertion(+), 24 deletions(-) >> >> >>>>> -static void piix3_xen_class_init(ObjectClass *klass, void *data) >>>>> -{ >>>>> - DeviceClass *dc = DEVICE_CLASS(klass); >>>>> - PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); >>>>> - >>>>> - k->realize = piix3_realize; >>>>> - /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ >>>>> - k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; >>>>> - dc->vmsd = &vmstate_piix3; >>>> >>>> IIUC, since this device is user-creatable, we can't simply remove it >>>> without going thru the deprecation process. >>> >>> AFAICS this device is actually not user-creatable since dc->user_creatable is set to false once in the base class. I think it is safe to remove the Xen class unless there are ABI issues. >> Great news! > > I don't know if this means the device is user-creatable: > > chuckz@bullseye:~$ qemu-system-i386 -device piix3-ide-xen,help > piix3-ide-xen options: > addr= - Slot and optional function number, example: 06.0 or 06 (default: -1) > failover_pair_id= > multifunction= - on/off (default: false) > rombar= - (default: 1) > romfile= > x-pcie-extcap-init= - on/off (default: true) > x-pcie-lnksta-dllla= - on/off (default: true) > > Today I am running qemu-5.2 on Debian 11, so this output is for > qemu 5.2, and that version of qemu has a piix3-ide-xen device. > Is that this same device that is being removed? If so, it seems to > me that at least as of qemu 5.2, the device was user-creatable. > > Chuck Good news! It looks the device was removed as user-creatable since version 5.2: chuckz@debian:~$ qemu-system-i386-7.50 -device help | grep piix name "piix3-usb-uhci", bus PCI name "piix4-usb-uhci", bus PCI name "piix3-ide", bus PCI name "piix4-ide", bus PCI chuckz@debian:~$ qemu-system-i386-7.50-bernhard-v2 -device help | grep piix name "piix3-usb-uhci", bus PCI name "piix4-usb-uhci", bus PCI name "piix3-ide", bus PCI name "piix4-ide", bus PCI chuckz@debian:~$ The piix3-ide-xen device is not present either with or without Bernhard's patches for current qemu 7.50, the development version for qemu 8.0 Cheers, Chuck