* [PATCH] hw/display/vmware_vga: fix probably typo
@ 2023-11-10 17:41 Alexandra Diupina
2023-11-13 6:32 ` Thomas Huth
2023-11-13 15:55 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Alexandra Diupina @ 2023-11-10 17:41 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Alexandra Diupina, Markus Armbruster, Thomas Huth, Juan Quintela,
qemu-devel, sdl.qemu
When calling trace_vmware_verify_rect_greater_than_bound() replace
"y" with "h" and y with h
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: 02218aedb1 ("hw/display/vmware_vga: replace fprintf calls with trace events")
Signed-off-by: Alexandra Diupina <adiupina@astralinux.ru>
---
hw/display/vmware_vga.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c
index 7490d43881..3f26bea190 100644
--- a/hw/display/vmware_vga.c
+++ b/hw/display/vmware_vga.c
@@ -336,8 +336,8 @@ static inline bool vmsvga_verify_rect(DisplaySurface *surface,
return false;
}
if (h > SVGA_MAX_HEIGHT) {
- trace_vmware_verify_rect_greater_than_bound(name, "y", SVGA_MAX_HEIGHT,
- y);
+ trace_vmware_verify_rect_greater_than_bound(name, "h", SVGA_MAX_HEIGHT,
+ h);
return false;
}
if (y + h > surface_height(surface)) {
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/display/vmware_vga: fix probably typo
2023-11-10 17:41 [PATCH] hw/display/vmware_vga: fix probably typo Alexandra Diupina
@ 2023-11-13 6:32 ` Thomas Huth
2023-11-13 15:55 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2023-11-13 6:32 UTC (permalink / raw)
To: Alexandra Diupina, Michael S. Tsirkin, Gerd Hoffmann,
Dmitry Fleytman
Cc: Markus Armbruster, Juan Quintela, qemu-devel, sdl.qemu,
QEMU Trivial
On 10/11/2023 18.41, Alexandra Diupina wrote:
> When calling trace_vmware_verify_rect_greater_than_bound() replace
> "y" with "h" and y with h
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 02218aedb1 ("hw/display/vmware_vga: replace fprintf calls with trace events")
> Signed-off-by: Alexandra Diupina <adiupina@astralinux.ru>
> ---
> hw/display/vmware_vga.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c
> index 7490d43881..3f26bea190 100644
> --- a/hw/display/vmware_vga.c
> +++ b/hw/display/vmware_vga.c
> @@ -336,8 +336,8 @@ static inline bool vmsvga_verify_rect(DisplaySurface *surface,
> return false;
> }
> if (h > SVGA_MAX_HEIGHT) {
> - trace_vmware_verify_rect_greater_than_bound(name, "y", SVGA_MAX_HEIGHT,
> - y);
> + trace_vmware_verify_rect_greater_than_bound(name, "h", SVGA_MAX_HEIGHT,
> + h);
> return false;
> }
> if (y + h > surface_height(surface)) {
That looks like a copy-n-paste bug, indeed!
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/display/vmware_vga: fix probably typo
2023-11-10 17:41 [PATCH] hw/display/vmware_vga: fix probably typo Alexandra Diupina
2023-11-13 6:32 ` Thomas Huth
@ 2023-11-13 15:55 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-11-13 15:55 UTC (permalink / raw)
To: Alexandra Diupina, Michael S. Tsirkin
Cc: Markus Armbruster, Thomas Huth, Juan Quintela, qemu-devel,
sdl.qemu
On 10/11/23 18:41, Alexandra Diupina wrote:
> When calling trace_vmware_verify_rect_greater_than_bound() replace
> "y" with "h" and y with h
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 02218aedb1 ("hw/display/vmware_vga: replace fprintf calls with trace events")
> Signed-off-by: Alexandra Diupina <adiupina@astralinux.ru>
> ---
> hw/display/vmware_vga.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, patch queued!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-13 15:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-10 17:41 [PATCH] hw/display/vmware_vga: fix probably typo Alexandra Diupina
2023-11-13 6:32 ` Thomas Huth
2023-11-13 15:55 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).