Re: [Qemu-devel] [PATCH 13/17] Strace is now working again with GUEST_BASE support.

[Mika Westerberg <mika.westerberg@iki.fi>]

[-- Attachment #1: Type: text/plain, Size: 1128 bytes --]

Hi,

On Wed, Apr 1, 2009 at 12:31 AM, Paul Brook <paul@codesourcery.com> wrote:

> On Tuesday 31 March 2009, riku.voipio@iki.fi wrote:
> > From: Mika Westerberg <mika.westerberg@iki.fi>
> >
> > Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
> > ---
> >  linux-user/strace.c    |  170
> > ++++++++++++++++++++++++++++++++++++++++++++++++ linux-user/strace.list |
> > 101 +++++++++++++++++-----------
> >  2 files changed, 232 insertions(+), 39 deletions(-)
>
> It would help if you included a description of what the patch actually
> does.
>
> > + * This function locks strings from guest memory and prints
> > + * strace output according to format specified in strace.list.
>
> This seems a poor way of implementing this. Much better would be to parse
> the
> format string and make this happen automatically for %s arguments and/or
> add
> a new format specifier.


This patch came from me and even I didn't like it when I wrote it :)

How about adding per syscall print function like in actual strace?  This way
we can get
more accurate (and correct format for flags etc.) output.

I will re-implement this asap.

Thanks,
MW

[-- Attachment #2: Type: text/html, Size: 1765 bytes --]