From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LouGQ-0000UM-Td for qemu-devel@nongnu.org; Wed, 01 Apr 2009 02:49:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LouGM-0000PV-6c for qemu-devel@nongnu.org; Wed, 01 Apr 2009 02:49:30 -0400 Received: from [199.232.76.173] (port=38716 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LouGM-0000Ol-16 for qemu-devel@nongnu.org; Wed, 01 Apr 2009 02:49:26 -0400 Received: from mail-fx0-f169.google.com ([209.85.220.169]:49828) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LouGK-0004zi-PZ for qemu-devel@nongnu.org; Wed, 01 Apr 2009 02:49:25 -0400 Received: by fxm17 with SMTP id 17so2503304fxm.34 for ; Tue, 31 Mar 2009 23:49:22 -0700 (PDT) MIME-Version: 1.0 Sender: mika.westerberg@gmail.com In-Reply-To: <200903312231.33726.paul@codesourcery.com> References: <3dc7b7b91d973c093c5899f299c055bb4d7b1c34.1238531009.git.riku.voipio@iki.fi> <200903312231.33726.paul@codesourcery.com> Date: Wed, 1 Apr 2009 09:49:22 +0300 Message-ID: <303c7fc10903312349s27740727w24b2af372ce6c3b1@mail.gmail.com> Subject: Re: [Qemu-devel] [PATCH 13/17] Strace is now working again with GUEST_BASE support. From: Mika Westerberg Content-Type: multipart/alternative; boundary=001485f6d4723659b1046678b788 Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: riku.voipio@iki.fi --001485f6d4723659b1046678b788 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hi, On Wed, Apr 1, 2009 at 12:31 AM, Paul Brook wrote: > On Tuesday 31 March 2009, riku.voipio@iki.fi wrote: > > From: Mika Westerberg > > > > Signed-off-by: Riku Voipio > > --- > > linux-user/strace.c | 170 > > ++++++++++++++++++++++++++++++++++++++++++++++++ linux-user/strace.list | > > 101 +++++++++++++++++----------- > > 2 files changed, 232 insertions(+), 39 deletions(-) > > It would help if you included a description of what the patch actually > does. > > > + * This function locks strings from guest memory and prints > > + * strace output according to format specified in strace.list. > > This seems a poor way of implementing this. Much better would be to parse > the > format string and make this happen automatically for %s arguments and/or > add > a new format specifier. This patch came from me and even I didn't like it when I wrote it :) How about adding per syscall print function like in actual strace? This way we can get more accurate (and correct format for flags etc.) output. I will re-implement this asap. Thanks, MW --001485f6d4723659b1046678b788 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi,

On Wed, Apr 1, 2009 at 12:31 AM, Paul= Brook <paul@= codesourcery.com> wrote:
On Tuesday 31 March 2009, riku.voipio@iki.fi wrote:
> From: Mika Westerberg <mi= ka.westerberg@iki.fi>
>
> Signed-off-by: Riku Voipio <r= iku.voipio@iki.fi>
> ---
> =A0linux-user/strace.c =A0 =A0| =A0170
> ++++++++++++++++++++++++++++++++++++++++++++++++ linux-user/strace.lis= t |
> 101 +++++++++++++++++-----------
> =A02 files changed, 232 insertions(+), 39 deletions(-)

It would help if you included a description of what the patch actuall= y does.

> + * This function locks strings from guest memory and prints
> + * strace output according to format specified in strace.list.

This seems a poor way of implementing this. Much better would be to p= arse the
format string and make this happen automatically for %s arguments and/or ad= d
a new format specifier.

This patch came fro= m me and even I didn't like it when I wrote it :)

<= div>How about adding per syscall print function like in actual strace? =A0T= his way we can get
more accurate (and correct format for flags etc.) output.
I will re-implement this asap.

Thanks= ,
MW


--001485f6d4723659b1046678b788--