From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83013C282DD for ; Thu, 23 May 2019 13:21:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53BDA2075B for ; Thu, 23 May 2019 13:21:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53BDA2075B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:36101 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTnej-0008O2-HN for qemu-devel@archiver.kernel.org; Thu, 23 May 2019 09:21:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54645) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTnRP-0005L6-6f for qemu-devel@nongnu.org; Thu, 23 May 2019 09:07:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTnRN-000228-6v for qemu-devel@nongnu.org; Thu, 23 May 2019 09:07:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49752) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hTnRH-0001yH-Ah; Thu, 23 May 2019 09:07:19 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7982764123; Thu, 23 May 2019 13:07:18 +0000 (UTC) Received: from dresden.str.redhat.com (unknown [10.40.205.176]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5B258600C1; Thu, 23 May 2019 13:07:16 +0000 (UTC) To: Sam Eiderman , kwolf@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org References: <20190502085029.30776-1-shmuel.eiderman@oracle.com> <20190502135828.42797-1-shmuel.eiderman@oracle.com> <20190502135828.42797-2-shmuel.eiderman@oracle.com> From: Max Reitz Openpgp: preference=signencrypt Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: <304c40b6-cf74-454d-648a-123ae6cae0a3@redhat.com> Date: Thu, 23 May 2019 15:07:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190502135828.42797-2-shmuel.eiderman@oracle.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="spJm7nTzuAYsoa65xhdixGmYjrdojYDSG" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 23 May 2019 13:07:18 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [Qemu-devel] [PATCH v2 1/3] qemu-img: rebase: Reuse parent BlockDriverState X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sagi.amit@oracle.com, arbel.moshe@oracle.com, liran.alon@oracle.com, eyal.moscovici@oracle.com, karl.heubaum@oracle.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --spJm7nTzuAYsoa65xhdixGmYjrdojYDSG From: Max Reitz To: Sam Eiderman , kwolf@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: eyal.moscovici@oracle.com, sagi.amit@oracle.com, karl.heubaum@oracle.com, liran.alon@oracle.com, arbel.moshe@oracle.com Message-ID: <304c40b6-cf74-454d-648a-123ae6cae0a3@redhat.com> Subject: Re: [PATCH v2 1/3] qemu-img: rebase: Reuse parent BlockDriverState References: <20190502085029.30776-1-shmuel.eiderman@oracle.com> <20190502135828.42797-1-shmuel.eiderman@oracle.com> <20190502135828.42797-2-shmuel.eiderman@oracle.com> In-Reply-To: <20190502135828.42797-2-shmuel.eiderman@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02.05.19 15:58, Sam Eiderman wrote: > In safe mode we open the entire chain, including the parent backing > file of the rebased file. > Do not open a new BlockBackend for the parent backing file, which > saves opening the rest of the chain twice, which for long chains > saves many "pricy" bdrv_open() calls. >=20 > Permissions for blk_new() were copied from blk_new_open() when > flags =3D 0. >=20 > Reviewed-by: Karl Heubaum > Reviewed-by: Eyal Moscovici > Signed-off-by: Sagi Amit > Co-developed-by: Sagi Amit > Signed-off-by: Sam Eiderman > --- > qemu-img.c | 29 ++++++++++++----------------- > 1 file changed, 12 insertions(+), 17 deletions(-) Looks good! But I=E2=80=99m afraid it will need a rebase on my =E2=80=9CAllow rebase = with no input base=E2=80=9D series (which is in master)... Max --spJm7nTzuAYsoa65xhdixGmYjrdojYDSG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAlzmmwIACgkQ9AfbAGHV z0DxZAgAk4vTkBI76crAG5mSp0zIY/NJ1i5EyOAJUlOKb23iOl6srnSgoOFvqStO WlrOQmiBJiCg13oczL4Kw4nvB3ywWMxH3Sp6w7i12XUjyGOWmZoAMXh9/fjIMUeM UckEOS9RjxfMzp9F2WighCLNELQmbp6iorhQILyNEvEXyrD2N+AmI0leGc7/eWMM rz562fwVH+M6m9LKpE+zYS0IRtfKp2IWW45tZO3R+Q4Z43GXN/O7LCkEU8hnJm75 yAXTF5ISGC8Z0VRLbeU2ZhPTTLLwFhWFvpM3oa5yYws+lLDFExGfoaEdk6+DE9BY miow4fr0htarB03xXFvUjMbWXRiG1g== =lWDW -----END PGP SIGNATURE----- --spJm7nTzuAYsoa65xhdixGmYjrdojYDSG--