From: David Hildenbrand <david@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org, bharata@linux.ibm.com
Subject: Re: [PATCH 3/8] softfloat: Tidy a * b + inf return
Date: Thu, 24 Sep 2020 09:37:35 +0200 [thread overview]
Message-ID: <30712261-3c25-8f7f-edea-12b0e369d2cb@redhat.com> (raw)
In-Reply-To: <20200924012453.659757-4-richard.henderson@linaro.org>
On 24.09.20 03:24, Richard Henderson wrote:
> No reason to set values in 'a', when we already
> have float_class_inf in 'c', and can flip that sign.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> fpu/softfloat.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/fpu/softfloat.c b/fpu/softfloat.c
> index 67cfa0fd82..9db55d2b11 100644
> --- a/fpu/softfloat.c
> +++ b/fpu/softfloat.c
> @@ -1380,9 +1380,8 @@ static FloatParts muladd_floats(FloatParts a, FloatParts b, FloatParts c,
> s->float_exception_flags |= float_flag_invalid;
> return parts_default_nan(s);
> } else {
> - a.cls = float_class_inf;
> - a.sign = c.sign ^ sign_flip;
> - return a;
> + c.sign ^= sign_flip;
> + return c;
> }
> }
>
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-09-24 7:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 1:24 [PATCH 0/8] softfloat: Implement float128_muladd Richard Henderson
2020-09-24 1:24 ` [PATCH 1/8] softfloat: Use mulu64 for mul64To128 Richard Henderson
2020-09-24 7:32 ` David Hildenbrand
2020-09-24 1:24 ` [PATCH 2/8] softfloat: Use int128.h for some operations Richard Henderson
2020-09-24 7:35 ` David Hildenbrand
2020-09-24 1:24 ` [PATCH 3/8] softfloat: Tidy a * b + inf return Richard Henderson
2020-09-24 7:37 ` David Hildenbrand [this message]
2020-09-24 1:24 ` [PATCH 4/8] softfloat: Add float_cmask and constants Richard Henderson
2020-09-24 7:40 ` David Hildenbrand
2020-09-24 1:24 ` [PATCH 5/8] softfloat: Inline pick_nan_muladd into its caller Richard Henderson
2020-09-24 7:42 ` David Hildenbrand
2020-09-24 1:24 ` [PATCH 6/8] softfloat: Implement float128_muladd Richard Henderson
2020-09-24 7:56 ` David Hildenbrand
2020-09-24 13:30 ` Richard Henderson
2020-09-25 9:17 ` David Hildenbrand
2020-09-24 1:24 ` [PATCH 7/8] softfloat: Use x86_64 assembly for {add,sub}{192,256} Richard Henderson
2020-09-24 1:24 ` [PATCH 8/8] softfloat: Use aarch64 " Richard Henderson
2020-09-24 8:00 ` [PATCH 0/8] softfloat: Implement float128_muladd David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30712261-3c25-8f7f-edea-12b0e369d2cb@redhat.com \
--to=david@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=bharata@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).