qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Hanna Reitz <hreitz@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
	Qemu-block <qemu-block@nongnu.org>, Kevin Wolf <kwolf@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: Failure in iotest 183
Date: Tue, 5 Jul 2022 11:58:46 +0200	[thread overview]
Message-ID: <308c543a-5f72-b0f4-15d4-b98d4db6f4f2@redhat.com> (raw)
In-Reply-To: <f629134d-0ce2-46df-13b5-30b735f6bd3d@redhat.com>

On 05.07.22 11:35, Thomas Huth wrote:
>
>  Hi!
>
> I've just hit a failure in iotest 183:
>
> --- /home/thuth/devel/qemu/tests/qemu-iotests/183.out
> +++ /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch/183/183.out.bad
> @@ -30,7 +30,7 @@
>         'arguments': { 'uri': 'unix:SOCK_DIR/migrate', 'blk': true } }
>  {"return": {}}
>  { 'execute': 'query-status' }
> -{"return": {"status": "postmigrate", "singlestep": false, "running": 
> false}}
> +{"return": {"status": "completed", "setup-time": 0, "downtime": 2448, 
> "total-time": 2872, "ram": {"total": 134750208, "postcopy-requests": 
> 0, "dirty-sync-count": 3, "multifd-bytes": 0, "pages-per-second": 0, 
> "downtime-bytes": 0, "page-size": 4096, "remaining": 0, 
> "postcopy-bytes": 0, "mbps": 188.63209192200557, "transferred": 
> 496829, "precopy-bytes": 496829, "duplicate": 32849, 
> "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 200704, "normal": 
> 49}}}

Weird because query-status cannot return something with '"status": 
"completed"' in it.  We can see the '"status": "postmigrate"' object 
somewhere below, so it seems to me like the silent=yes part for the 
query-migrate execution didn’t work as intended.

(And it does seem to work below, when waiting for a “100 %” to appear on 
$dest.)

It’s been a while since we’ve touched common.qemu, so nothing comes to 
my mind immediately that might have broken this.

>
>  === Do some I/O on the destination ===
>
> @@ -53,8 +53,31 @@
>  === Shut down and check image ===
>
>  {"execute":"quit"}
> +{"return": {"status": "completed", "setup-time": 0, "downtime": 2448, 
> "total-time": 2872, "ram": {"total": 134750208, "postcopy-requests": 
> 0, "dirty-sync-count": 3, "multifd-bytes": 0, "pages-per-second": 0, 
> "downtime-bytes": 0, "page-size": 4096, "remaining": 0, 
> "postcopy-bytes": 0, "mbps": 188.63209192200557, "transferred": 
> 496829, "precopy-bytes": 496829, "duplicate": 32849, 
> "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 200704, "normal": 
> 49}}}
> +{"execute":"quit"}
>  {"return": {}}
> -{"execute":"quit"}
> +{"return": {"status": "completed", "setup-time": 0, "downtime": 2448, 
> "total-time": 2872, "ram": {"total": 134750208, "postcopy-requests": 
> 0, "dirty-sync-count": 3, "multifd-bytes": 0, "pages-per-second": 0, 
> "downtime-bytes": 0, "page-size": 4096, "remaining": 0, 
> "postcopy-bytes": 0, "mbps": 188.63209192200557, "transferred": 
> 496829, "precopy-bytes": 496829, "duplicate": 32849, 
> "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 200704, "normal": 
> 49}}}
> +{"return": {"status": "completed", "setup-time": 0, "downtime": 2448, 
> "total-time": 2872, "ram": {"total": 134750208, "postcopy-requests": 
> 0, "dirty-sync-count": 3, "multifd-bytes": 0, "pages-per-second": 0, 
> "downtime-bytes": 0, "page-size": 4096, "remaining": 0, 
> "postcopy-bytes": 0, "mbps": 188.63209192200557, "transferred": 
> 496829, "precopy-bytes": 496829, "duplicate": 32849, 
> "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 200704, "normal": 
> 49}}}
> +{"return": {"status": "completed", "setup-time": 0, "downtime": 2448, 
> "total-time": 2872, "ram": {"total": 134750208, "postcopy-requests": 
> 0, "dirty-sync-count": 3, "multifd-bytes": 0, "pages-per-second": 0, 
> "downtime-bytes": 0, "page-size": 4096, "remaining": 0, 
> "postcopy-bytes": 0, "mbps": 188.63209192200557, "transferred": 
> 496829, "precopy-bytes": 496829, "duplicate": 32849, 
> "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 200704, "normal": 
> 49}}}
> +{"return": {"status": "completed", "setup-time": 0, "downtime": 2448, 
> "total-time": 2872, "ram": {"total": 134750208, "postcopy-requests": 
> 0, "dirty-sync-count": 3, "multifd-bytes": 0, "pages-per-second": 0, 
> "downtime-bytes": 0, "page-size": 4096, "remaining": 0, 
> "postcopy-bytes": 0, "mbps": 188.63209192200557, "transferred": 
> 496829, "precopy-bytes": 496829, "duplicate": 32849, 
> "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 200704, "normal": 
> 49}}}
> +{"return": {"status": "completed", "setup-time": 0, "downtime": 2448, 
> "total-time": 2872, "ram": {"total": 134750208, "postcopy-requests": 
> 0, "dirty-sync-count": 3, "multifd-bytes": 0, "pages-per-second": 0, 
> "downtime-bytes": 0, "page-size": 4096, "remaining": 0, 
> "postcopy-bytes": 0, "mbps": 188.63209192200557, "transferred": 
> 496829, "precopy-bytes": 496829, "duplicate": 32849, 
> "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 200704, "normal": 
> 49}}}
> +{"return": {"status": "completed", "setup-time": 0, "downtime": 2448, 
> "total-time": 2872, "ram": {"total": 134750208, "postcopy-requests": 
> 0, "dirty-sync-count": 3, "multifd-bytes": 0, "pages-per-second": 0, 
> "downtime-bytes": 0, "page-size": 4096, "remaining": 0, 
> "postcopy-bytes": 0, "mbps": 188.63209192200557, "transferred": 
> 496829, "precopy-bytes": 496829, "duplicate": 32849, 
> "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 200704, "normal": 
> 49}}}
> +{"return": {"status": "completed", "setup-time": 0, "downtime": 2448, 
> "total-time": 2872, "ram": {"total": 134750208, "postcopy-requests": 
> 0, "dirty-sync-count": 3, "multifd-bytes": 0, "pages-per-second": 0, 
> "downtime-bytes": 0, "page-size": 4096, "remaining": 0, 
> "postcopy-bytes": 0, "mbps": 188.63209192200557, "transferred": 
> 496829, "precopy-bytes": 496829, "duplicate": 32849, 
> "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 200704, "normal": 
> 49}}}
> +{"return": {"status": "completed", "setup-time": 0, "downtime": 2448, 
> "total-time": 2872, "ram": {"total": 134750208, "postcopy-requests": 
> 0, "dirty-sync-count": 3, "multifd-bytes": 0, "pages-per-second": 0, 
> "downtime-bytes": 0, "page-size": 4096, "remaining": 0, 
> "postcopy-bytes": 0, "mbps": 188.63209192200557, "transferred": 
> 496829, "precopy-bytes": 496829, "duplicate": 32849, 
> "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 200704, "normal": 
> 49}}}
> +{"return": {"status": "completed", "setup-time": 0, "downtime": 2448, 
> "total-time": 2872, "ram": {"total": 134750208, "postcopy-requests": 
> 0, "dirty-sync-count": 3, "multifd-bytes": 0, "pages-per-second": 0, 
> "downtime-bytes": 0, "page-size": 4096, "remaining": 0, 
> "postcopy-bytes": 0, "mbps": 188.63209192200557, "transferred": 
> 496829, "precopy-bytes": 496829, "duplicate": 32849, 
> "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 200704, "normal": 
> 49}}}
> +{"return": {"status": "completed", "setup-time": 0, "downtime": 2448, 
> "total-time": 2872, "ram": {"total": 134750208, "postcopy-requests": 
> 0, "dirty-sync-count": 3, "multifd-bytes": 0, "pages-per-second": 0, 
> "downtime-bytes": 0, "page-size": 4096, "remaining": 0, 
> "postcopy-bytes": 0, "mbps": 188.63209192200557, "transferred": 
> 496829, "precopy-bytes": 496829, "duplicate": 32849, 
> "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 200704, "normal": 
> 49}}}
> +{"return": {"status": "completed", "setup-time": 0, "downtime": 2448, 
> "total-time": 2872, "ram": {"total": 134750208, "postcopy-requests": 
> 0, "dirty-sync-count": 3, "multifd-bytes": 0, "pages-per-second": 0, 
> "downtime-bytes": 0, "page-size": 4096, "remaining": 0, 
> "postcopy-bytes": 0, "mbps": 188.63209192200557, "transferred": 
> 496829, "precopy-bytes": 496829, "duplicate": 32849, 
> "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 200704, "normal": 
> 49}}}
> +{"return": {"status": "completed", "setup-time": 0, "downtime": 2448, 
> "total-time": 2872, "ram": {"total": 134750208, "postcopy-requests": 
> 0, "dirty-sync-count": 3, "multifd-bytes": 0, "pages-per-second": 0, 
> "downtime-bytes": 0, "page-size": 4096, "remaining": 0, 
> "postcopy-bytes": 0, "mbps": 188.63209192200557, "transferred": 
> 496829, "precopy-bytes": 496829, "duplicate": 32849, 
> "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 200704, "normal": 
> 49}}}
> +{"return": {"status": "completed", "setup-time": 0, "downtime": 2448, 
> "total-time": 2872, "ram": {"total": 134750208, "postcopy-requests": 
> 0, "dirty-sync-count": 3, "multifd-bytes": 0, "pages-per-second": 0, 
> "downtime-bytes": 0, "page-size": 4096, "remaining": 0, 
> "postcopy-bytes": 0, "mbps": 188.63209192200557, "transferred": 
> 496829, "precopy-bytes": 496829, "duplicate": 32849, 
> "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 200704, "normal": 
> 49}}}
> +{"return": {"status": "completed", "setup-time": 0, "downtime": 2448, 
> "total-time": 2872, "ram": {"total": 134750208, "postcopy-requests": 
> 0, "dirty-sync-count": 3, "multifd-bytes": 0, "pages-per-second": 0, 
> "downtime-bytes": 0, "page-size": 4096, "remaining": 0, 
> "postcopy-bytes": 0, "mbps": 188.63209192200557, "transferred": 
> 496829, "precopy-bytes": 496829, "duplicate": 32849, 
> "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 200704, "normal": 
> 49}}}
> +{"return": {"status": "completed", "setup-time": 0, "downtime": 2448, 
> "total-time": 2872, "ram": {"total": 134750208, "postcopy-requests": 
> 0, "dirty-sync-count": 3, "multifd-bytes": 0, "pages-per-second": 0, 
> "downtime-bytes": 0, "page-size": 4096, "remaining": 0, 
> "postcopy-bytes": 0, "mbps": 188.63209192200557, "transferred": 
> 496829, "precopy-bytes": 496829, "duplicate": 32849, 
> "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 200704, "normal": 
> 49}}}
> +{"return": {"status": "completed", "setup-time": 0, "downtime": 2448, 
> "total-time": 2872, "ram": {"total": 134750208, "postcopy-requests": 
> 0, "dirty-sync-count": 3, "multifd-bytes": 0, "pages-per-second": 0, 
> "downtime-bytes": 0, "page-size": 4096, "remaining": 0, 
> "postcopy-bytes": 0, "mbps": 188.63209192200557, "transferred": 
> 496829, "precopy-bytes": 496829, "duplicate": 32849, 
> "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 200704, "normal": 
> 49}}}
> +{"return": {"status": "completed", "setup-time": 0, "downtime": 2448, 
> "total-time": 2872, "ram": {"total": 134750208, "postcopy-requests": 
> 0, "dirty-sync-count": 3, "multifd-bytes": 0, "pages-per-second": 0, 
> "downtime-bytes": 0, "page-size": 4096, "remaining": 0, 
> "postcopy-bytes": 0, "mbps": 188.63209192200557, "transferred": 
> 496829, "precopy-bytes": 496829, "duplicate": 32849, 
> "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 200704, "normal": 
> 49}}}
> +{"return": {"status": "completed", "setup-time": 0, "downtime": 2448, 
> "total-time": 2872, "ram": {"total": 134750208, "postcopy-requests": 
> 0, "dirty-sync-count": 3, "multifd-bytes": 0, "pages-per-second": 0, 
> "downtime-bytes": 0, "page-size": 4096, "remaining": 0, 
> "postcopy-bytes": 0, "mbps": 188.63209192200557, "transferred": 
> 496829, "precopy-bytes": 496829, "duplicate": 32849, 
> "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 200704, "normal": 
> 49}}}
> +{"return": {"status": "completed", "setup-time": 0, "downtime": 2448, 
> "total-time": 2872, "ram": {"total": 134750208, "postcopy-requests": 
> 0, "dirty-sync-count": 3, "multifd-bytes": 0, "pages-per-second": 0, 
> "downtime-bytes": 0, "page-size": 4096, "remaining": 0, 
> "postcopy-bytes": 0, "mbps": 188.63209192200557, "transferred": 
> 496829, "precopy-bytes": 496829, "duplicate": 32849, 
> "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 200704, "normal": 
> 49}}}
> +{"return": {"status": "completed", "setup-time": 0, "downtime": 2448, 
> "total-time": 2872, "ram": {"total": 134750208, "postcopy-requests": 
> 0, "dirty-sync-count": 3, "multifd-bytes": 0, "pages-per-second": 0, 
> "downtime-bytes": 0, "page-size": 4096, "remaining": 0, 
> "postcopy-bytes": 0, "mbps": 188.63209192200557, "transferred": 
> 496829, "precopy-bytes": 496829, "duplicate": 32849, 
> "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 200704, "normal": 
> 49}}}
> +{"return": {"status": "completed", "setup-time": 0, "downtime": 2448, 
> "total-time": 2872, "ram": {"total": 134750208, "postcopy-requests": 
> 0, "dirty-sync-count": 3, "multifd-bytes": 0, "pages-per-second": 0, 
> "downtime-bytes": 0, "page-size": 4096, "remaining": 0, 
> "postcopy-bytes": 0, "mbps": 188.63209192200557, "transferred": 
> 496829, "precopy-bytes": 496829, "duplicate": 32849, 
> "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 200704, "normal": 
> 49}}}
> +{"return": {"status": "postmigrate", "singlestep": false, "running": 
> false}}
>  {"return": {}}
>  {"timestamp": {"seconds":  TIMESTAMP, "microseconds": TIMESTAMP}, 
> "event": "SHUTDOWN", "data": {"guest": false, "reason": "host-qmp-quit"}}
>  {"timestamp": {"seconds":  TIMESTAMP, "microseconds": TIMESTAMP}, 
> "event": "SHUTDOWN", "data": {"guest": false, "reason": "host-qmp-quit"}}
>
> Is that a known problem already? (I haven't seen anything
> related on the list)

I’ve never hit this so far.

The only things to try I can come up with would be to bisect, or to try 
adding `silent=$silent` to the `_timed_wait_for` calls in `send_qemu_cmd`...

Hanna



  reply	other threads:[~2022-07-05  9:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-05  9:35 Failure in iotest 183 Thomas Huth
2022-07-05  9:58 ` Hanna Reitz [this message]
2022-07-05 10:20   ` Thomas Huth
2022-07-21  9:01     ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=308c543a-5f72-b0f4-15d4-b98d4db6f4f2@redhat.com \
    --to=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).