qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Phil Dennis-Jordan <phil@philjordan.eu>
Cc: qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>,
	Eduardo Habkost <ehabkost@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] x86-KVM: Supply TSC and APIC clock rates to guest like VMWare
Date: Wed, 18 Jan 2017 17:22:45 +0100	[thread overview]
Message-ID: <30d84df6-c1de-d08f-fe82-daafabd1fba8@redhat.com> (raw)
In-Reply-To: <CAAibmn2X-b4yZw6Od=f96k3gkhM7=DGV-0RKG=XWU=Ti0rBWPQ@mail.gmail.com>



On 18/01/2017 17:16, Phil Dennis-Jordan wrote:
> On 18 January 2017 at 17:10, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> You enable vmware-cpuid-freq unconditionally.  But then you actually
>> publish 0x40000010 only if INVTSC is set.
> Right, got it, thanks. What about the Hyper-V conflict? That will be
> vastly more probable if the option is on by default. Don't publish
> leaf 0x40000010, print the warning and carry on in this case (as the
> patch does at the moment)?

Probably it's simplest to remove the warning altogether.

Paolo

  reply	other threads:[~2017-01-18 16:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-18 14:24 [Qemu-devel] [PATCH] x86-KVM: Supply TSC and APIC clock rates to guest like VMWare Phil Dennis-Jordan
2017-01-18 15:05 ` Paolo Bonzini
2017-01-18 15:23   ` Eduardo Habkost
2017-01-18 16:02   ` Phil Dennis-Jordan
2017-01-18 16:10     ` Paolo Bonzini
2017-01-18 16:16       ` Phil Dennis-Jordan
2017-01-18 16:22         ` Paolo Bonzini [this message]
2017-01-18 16:04   ` Phil Dennis-Jordan
2017-01-18 17:15     ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30d84df6-c1de-d08f-fe82-daafabd1fba8@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=phil@philjordan.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).