From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43623) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTt0c-0001kb-2o for qemu-devel@nongnu.org; Wed, 18 Jan 2017 11:22:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cTt0b-0000g4-Cb for qemu-devel@nongnu.org; Wed, 18 Jan 2017 11:22:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58300) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cTt0b-0000fX-6u for qemu-devel@nongnu.org; Wed, 18 Jan 2017 11:22:49 -0500 References: <1484749457-87117-1-git-send-email-phil@philjordan.eu> From: Paolo Bonzini Message-ID: <30d84df6-c1de-d08f-fe82-daafabd1fba8@redhat.com> Date: Wed, 18 Jan 2017 17:22:45 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] x86-KVM: Supply TSC and APIC clock rates to guest like VMWare List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Phil Dennis-Jordan Cc: qemu-devel@nongnu.org, Richard Henderson , Eduardo Habkost , Marcelo Tosatti , kvm@vger.kernel.org On 18/01/2017 17:16, Phil Dennis-Jordan wrote: > On 18 January 2017 at 17:10, Paolo Bonzini wrote: >> You enable vmware-cpuid-freq unconditionally. But then you actually >> publish 0x40000010 only if INVTSC is set. > Right, got it, thanks. What about the Hyper-V conflict? That will be > vastly more probable if the option is on by default. Don't publish > leaf 0x40000010, print the warning and carry on in this case (as the > patch does at the moment)? Probably it's simplest to remove the warning altogether. Paolo