From: Thomas Huth <thuth@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, lvivier@redhat.com, minyard@acm.org,
yc-core@yandex-team.ru, den-plotnikov@yandex-team.ru,
daniil.tatianin@yandex.ru
Subject: Re: [PATCH] ipmi-bt-test: force ipv4
Date: Thu, 19 Oct 2023 07:17:52 +0200 [thread overview]
Message-ID: <30d882f4-fcda-48c6-a018-bbac57b7c65f@redhat.com> (raw)
In-Reply-To: <20231018191123.1176602-1-vsementsov@yandex-team.ru>
On 18/10/2023 21.11, Vladimir Sementsov-Ogievskiy wrote:
> We open ipv4 listening socket. But "localhost" in qemu parameters may
> load to Qemu trying to connect with ipv6 and fail with "Connection
> refused". Force ipv4 by using ipv4 ip address.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
> tests/qtest/ipmi-bt-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/ipmi-bt-test.c b/tests/qtest/ipmi-bt-test.c
> index ed431e34e6..383239bcd4 100644
> --- a/tests/qtest/ipmi-bt-test.c
> +++ b/tests/qtest/ipmi-bt-test.c
> @@ -411,7 +411,7 @@ int main(int argc, char **argv)
> g_test_init(&argc, &argv, NULL);
>
> global_qtest = qtest_initf(
> - " -chardev socket,id=ipmi0,host=localhost,port=%d,reconnect=10"
> + " -chardev socket,id=ipmi0,host=127.0.0.1,port=%d,reconnect=10"
> " -device ipmi-bmc-extern,chardev=ipmi0,id=bmc0"
> " -device isa-ipmi-bt,bmc=bmc0", emu_port);
> qtest_irq_intercept_in(global_qtest, "ioapic");
Thanks, I'll queue it for my next pull request.
Acked-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2023-10-19 5:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 19:11 [PATCH] ipmi-bt-test: force ipv4 Vladimir Sementsov-Ogievskiy
2023-10-19 5:17 ` Thomas Huth [this message]
2023-10-19 18:30 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30d882f4-fcda-48c6-a018-bbac57b7c65f@redhat.com \
--to=thuth@redhat.com \
--cc=daniil.tatianin@yandex.ru \
--cc=den-plotnikov@yandex-team.ru \
--cc=lvivier@redhat.com \
--cc=minyard@acm.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
--cc=yc-core@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).