From: Eric Blake <eblake@redhat.com>
To: Like Xu <like.xu@linux.intel.com>, qemu-trivial@nongnu.org
Cc: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] doc: update .gitignore and fix typos for docs in tree
Date: Wed, 20 Feb 2019 07:45:31 -0600 [thread overview]
Message-ID: <30d93f35-8ee4-e6e5-69e6-237322ab816c@redhat.com> (raw)
In-Reply-To: <b10cd713-1441-92fb-59e3-4b3162728070@linux.intel.com>
On 2/19/19 11:39 PM, Like Xu wrote:
> On 2019/2/20 11:09, Eric Blake wrote:
>> On 2/20/19 2:55 AM, Like Xu wrote:
>>> Signed-off-by: Like Xu <like.xu@linux.intel.com>
>>
>> This feels like two independent patches - the .gitignore change is
>> different from typo fixes.
>>
>> Actually, for .gitignore, you could just as easily do:
>>
>> echo '*.patch' >> .git/info/exclude
>>
>> and fix it so you never commit patch files locally, while still leaving
>> them visible through 'git status' to other users. I actually like
>> knowing when I have stale patch files lying around, so that I can 'rm'
>> them before creating my next patch batch and using 'git send-email
>> *.patch' - but of course, I could just as easily add '!*.patch' to my
>> .git/info/exclude to override the project default if we decide to go
>> with your patch.
>
> Adding '*.patch' to .gitignore is consistent with LKML tree.
Fair enough - but then make it a separate patch, and include that
justification in your commit message.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2019-02-20 15:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 8:55 [Qemu-devel] [PATCH] doc: update .gitignore and fix typos for docs in tree Like Xu
2019-02-20 3:00 ` Wei Yang
2019-02-20 3:09 ` Eric Blake
2019-02-20 5:39 ` Like Xu
2019-02-20 13:45 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30d93f35-8ee4-e6e5-69e6-237322ab816c@redhat.com \
--to=eblake@redhat.com \
--cc=laurent@vivier.eu \
--cc=like.xu@linux.intel.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).