qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Stafford Horne <shorne@gmail.com>, Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines
Date: Mon, 3 Jun 2019 10:45:14 +0200	[thread overview]
Message-ID: <30db7d52-b304-da2d-f84d-42a57dc28135@redhat.com> (raw)
In-Reply-To: <20190531033601.GB3379@lianli.shorne-pla.net>

On 5/31/19 5:36 AM, Stafford Horne wrote:
> On Wed, May 29, 2019 at 05:08:52PM +0200, Markus Armbruster wrote:
>> When scripts/get_maintainer.pl reports something like
>>
>>     John Doe <jdoe@example.org> (maintainer:Overall)
>>
>> the user is left to wonder *which* of our three "Overall" sections
>> applies.  We have three, one each under "Guest CPU cores (TCG)",
>> "Guest CPU Cores (KVM)", and "Overall usermode emulation".
>>
>> Rename sections under
>>
>> * "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"
>>
>> * "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"
>>
>> * "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"
>>
>> * "Architecture support" from "FOO" to "FOO general architecture
>>   support"
>>
>> * "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"
>>
>> While there,
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
>>  1 file changed, 39 insertions(+), 39 deletions(-)
> 
> ... 
> 
>> -OpenRISC
>> +OpenRISC CPU cores (TCG)
>>  M: Stafford Horne <shorne@gmail.com>
>>  S: Odd Fixes
>>  F: target/openrisc/
>>  F: hw/openrisc/
>>  F: tests/tcg/openrisc/
>>  
> 
> As directories listed there I look over both target/ (TCG?) and hw/.
> Would it be better to be 'OpenRISC general architecture'?

There is a historical separation between target/ and hw/ because they
cover different concepts, and have different maintainers/reviewers.

- target/$arch/ is for TCG/KVM
- hw/ is for machines and their devices
  (some devices are reused by multiple archs)

Although the separation is not always clear (some devices are tied to an
architecture, some architecture instruction directly access devices) I'd
prefer we keep 2 distincts MAINTAINERS sections (keeping you maintainer
of both). This will ease developper with specific background/interests
to volunteer to a particular section.

Regards,

Phil.


  parent reply	other threads:[~2019-06-03  8:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-29 15:08 [Qemu-devel] [PATCH 0/3] MAINTAINERS: Clean up and improve section headlines Markus Armbruster
2019-05-29 15:08 ` [Qemu-devel] [PATCH 1/3] MAINTAINERS: Drop redundant L: qemu-devel@nongnu.org Markus Armbruster
2019-05-29 15:52   ` Philippe Mathieu-Daudé
2019-05-29 19:09     ` Markus Armbruster
2019-05-29 15:08 ` [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines Markus Armbruster
2019-05-29 15:16   ` Eric Blake
2019-05-29 15:56     ` Philippe Mathieu-Daudé
2019-05-29 19:09       ` Markus Armbruster
2019-05-29 16:03   ` Philippe Mathieu-Daudé
2019-05-29 19:16     ` Markus Armbruster
2019-05-30 22:40   ` Aleksandar Markovic
2019-06-03  8:29     ` Markus Armbruster
2019-06-03  9:35       ` Cornelia Huck
2019-05-31  3:36   ` Stafford Horne
2019-06-03  8:32     ` Markus Armbruster
2019-06-03  8:45     ` Philippe Mathieu-Daudé [this message]
2019-06-04 10:33       ` Stafford Horne
2019-06-06 17:01         ` Markus Armbruster
2019-06-06 20:56           ` Stafford Horne
2019-05-29 15:08 ` [Qemu-devel] [PATCH 3/3] MAINTAINERS: Polish headline decorations Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30db7d52-b304-da2d-f84d-42a57dc28135@redhat.com \
    --to=philmd@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=shorne@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).