From: Richard Henderson <richard.henderson@linaro.org>
To: frank.chang@sifive.com, qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
Sagar Karandikar <sagark@eecs.berkeley.edu>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Subject: Re: [RFC v4 22/70] target/riscv: rvv-1.0: amo operations
Date: Sat, 29 Aug 2020 11:50:17 -0700 [thread overview]
Message-ID: <30dcedd1-84e3-70c4-7b8b-d985608b81c5@linaro.org> (raw)
In-Reply-To: <20200817084955.28793-23-frank.chang@sifive.com>
On 8/17/20 1:49 AM, frank.chang@sifive.com wrote:
> +static bool vext_check_amo(DisasContext *s, int vd, int vs2,
> + int wd, int vm, uint8_t eew)
> +{
> + int8_t emul = ctzl(eew) - (s->sew + 3) + s->lmul;
> + bool ret = has_ext(s, RVA) &&
> + (1 << s->sew >= 4) &&
> + (1 << s->sew <= sizeof(target_ulong)) &&
> + (eew <= (sizeof(target_ulong) << 3)) &&
> + require_align(vd, 1 << s->lmul) &&
> + require_align(vs2, 1 << emul) &&
> + (emul >= -3 && emul <= 3);
> + if (wd) {
> + ret &= require_vm(vm, vd);
> + if (eew > (1 << (s->sew + 3))) {
> + if (vd != vs2) {
> + ret &= require_noover(vd, 1 << s->lmul, vs2, 1 << emul);
> + }
> + } else if (eew < (1 << (s->sew + 3))) {
> + if (emul < 0) {
> + ret &= require_noover(vd, 1 << s->lmul, vs2, 1 << emul);
> + } else {
> + ret &= require_noover_widen(vd, 1 << s->lmul, vs2, 1 << emul);
> + }
> + }
> + }
> + return ret;
> +}
Same comments for EEW and require_noover.
r~
next prev parent reply other threads:[~2020-08-29 18:51 UTC|newest]
Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 8:48 [RFC v4 00/70] support vector extension v1.0 frank.chang
2020-08-17 8:48 ` [RFC v4 01/70] target/riscv: drop vector 0.7.1 and add 1.0 support frank.chang
2020-08-17 8:48 ` [RFC v4 02/70] target/riscv: Use FIELD_EX32() to extract wd field frank.chang
2020-08-17 8:48 ` [RFC v4 03/70] target/riscv: rvv-1.0: add mstatus VS field frank.chang
2020-08-17 8:48 ` [RFC v4 04/70] target/riscv: rvv-1.0: add sstatus " frank.chang
2020-08-17 8:48 ` [RFC v4 05/70] target/riscv: rvv-1.0: introduce writable misa.v field frank.chang
2020-08-17 8:48 ` [RFC v4 06/70] target/riscv: rvv-1.0: add translation-time vector context status frank.chang
2020-08-17 8:48 ` [RFC v4 07/70] target/riscv: rvv-1.0: remove rvv related codes from fcsr registers frank.chang
2020-08-29 15:49 ` Richard Henderson
2020-08-17 8:48 ` [RFC v4 08/70] target/riscv: rvv-1.0: add vcsr register frank.chang
2020-08-17 8:48 ` [RFC v4 09/70] target/riscv: rvv-1.0: add vlenb register frank.chang
2020-08-17 8:48 ` [RFC v4 10/70] target/riscv: rvv-1.0: check MSTATUS_VS when accessing vector csr registers frank.chang
2020-08-17 8:48 ` [RFC v4 11/70] target/riscv: rvv-1.0: remove MLEN calculations frank.chang
2020-08-17 8:48 ` [RFC v4 12/70] target/riscv: rvv-1.0: add fractional LMUL frank.chang
2020-08-29 15:51 ` Richard Henderson
2020-08-17 8:48 ` [RFC v4 13/70] target/riscv: rvv-1.0: add VMA and VTA frank.chang
2020-08-17 8:48 ` [RFC v4 14/70] target/riscv: rvv-1.0: update check functions frank.chang
2020-08-29 17:50 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 15/70] target/riscv: introduce more imm value modes in translator functions frank.chang
2020-08-29 17:51 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 16/70] target/riscv: rvv:1.0: add translation-time nan-box helper function frank.chang
2020-08-29 17:53 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 17/70] target/riscv: rvv-1.0: configure instructions frank.chang
2020-09-25 8:51 ` Frank Chang
2020-09-25 18:28 ` Richard Henderson
2020-09-26 5:05 ` Frank Chang
2020-08-17 8:49 ` [RFC v4 18/70] target/riscv: rvv-1.0: stride load and store instructions frank.chang
2020-08-29 18:10 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 19/70] target/riscv: rvv-1.0: index " frank.chang
2020-08-29 18:33 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 20/70] target/riscv: rvv-1.0: fix address index overflow bug of indexed load/store insns frank.chang
2020-08-29 18:34 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 21/70] target/riscv: rvv-1.0: fault-only-first unit stride load frank.chang
2020-08-29 18:36 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 22/70] target/riscv: rvv-1.0: amo operations frank.chang
2020-08-29 18:50 ` Richard Henderson [this message]
2020-08-17 8:49 ` [RFC v4 23/70] target/riscv: rvv-1.0: load/store whole register instructions frank.chang
2020-08-29 19:13 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 24/70] target/riscv: rvv-1.0: update vext_max_elems() for load/store insns frank.chang
2020-08-29 19:30 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 25/70] target/riscv: rvv-1.0: take fractional LMUL into vector max elements calculation frank.chang
2020-08-29 19:36 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 26/70] target/riscv: rvv-1.0: floating-point square-root instruction frank.chang
2020-08-17 8:49 ` [RFC v4 27/70] target/riscv: rvv-1.0: floating-point classify instructions frank.chang
2020-08-17 8:49 ` [RFC v4 28/70] target/riscv: rvv-1.0: mask population count instruction frank.chang
2020-08-17 8:49 ` [RFC v4 29/70] target/riscv: rvv-1.0: find-first-set mask bit instruction frank.chang
2020-08-17 8:49 ` [RFC v4 30/70] target/riscv: rvv-1.0: set-X-first mask bit instructions frank.chang
2020-08-17 8:49 ` [RFC v4 31/70] target/riscv: rvv-1.0: iota instruction frank.chang
2020-08-17 8:49 ` [RFC v4 32/70] target/riscv: rvv-1.0: element index instruction frank.chang
2020-08-17 8:49 ` [RFC v4 33/70] target/riscv: rvv-1.0: allow load element with sign-extended frank.chang
2020-08-17 8:49 ` [RFC v4 34/70] target/riscv: rvv-1.0: register gather instructions frank.chang
2020-08-29 19:52 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 35/70] target/riscv: rvv-1.0: integer scalar move instructions frank.chang
2020-08-17 8:49 ` [RFC v4 36/70] target/riscv: rvv-1.0: floating-point move instruction frank.chang
2020-08-29 20:00 ` Richard Henderson
2020-08-29 20:03 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 37/70] target/riscv: rvv-1.0: floating-point scalar move instructions frank.chang
2020-08-29 20:07 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 38/70] target/riscv: rvv-1.0: whole register " frank.chang
2020-08-29 20:08 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 39/70] target/riscv: rvv-1.0: integer extension instructions frank.chang
2020-08-17 8:49 ` [RFC v4 40/70] target/riscv: rvv-1.0: single-width averaging add and subtract instructions frank.chang
2020-08-29 20:11 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 41/70] target/riscv: rvv-1.0: single-width bit shift instructions frank.chang
2020-08-17 8:49 ` [RFC v4 42/70] target/riscv: rvv-1.0: integer add-with-carry/subtract-with-borrow frank.chang
2020-08-29 20:16 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 43/70] target/riscv: rvv-1.0: narrowing integer right shift instructions frank.chang
2020-08-17 8:49 ` [RFC v4 44/70] target/riscv: rvv-1.0: widening integer multiply-add instructions frank.chang
2020-08-17 8:49 ` [RFC v4 45/70] target/riscv: rvv-1.0: add Zvqmac extension frank.chang
2020-08-29 20:17 ` Richard Henderson
2020-08-29 20:21 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 46/70] target/riscv: rvv-1.0: quad-widening integer multiply-add instructions frank.chang
2020-08-29 20:22 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 47/70] target/riscv: rvv-1.0: single-width saturating add and subtract instructions frank.chang
2020-08-29 20:23 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 48/70] target/riscv: rvv-1.0: integer comparison instructions frank.chang
2020-08-29 20:23 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 49/70] target/riscv: use softfloat lib float16 comparison functions frank.chang
2020-08-17 8:49 ` [RFC v4 50/70] target/riscv: rvv-1.0: floating-point compare instructions frank.chang
2020-08-29 20:25 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 51/70] target/riscv: rvv-1.0: mask-register logical instructions frank.chang
2020-08-29 20:25 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 52/70] target/riscv: rvv-1.0: slide instructions frank.chang
2020-08-29 20:28 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 53/70] target/riscv: rvv-1.0: floating-point " frank.chang
2020-08-29 20:33 ` Richard Henderson
2020-09-25 8:21 ` Frank Chang
2020-09-25 18:31 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 54/70] target/riscv: rvv-1.0: narrowing fixed-point clip instructions frank.chang
2020-08-17 8:49 ` [RFC v4 55/70] target/riscv: rvv-1.0: single-width floating-point reduction frank.chang
2020-08-29 23:50 ` Richard Henderson
2020-08-29 23:58 ` Richard Henderson
2020-08-31 18:50 ` Chih-Min Chao
2020-08-17 8:49 ` [RFC v4 56/70] target/riscv: rvv-1.0: widening floating-point reduction instructions frank.chang
2020-08-29 23:50 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 57/70] target/riscv: rvv-1.0: single-width scaling shift instructions frank.chang
2020-08-29 23:54 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 58/70] target/riscv: rvv-1.0: remove widening saturating scaled multiply-add frank.chang
2020-08-17 8:49 ` [RFC v4 59/70] target/riscv: rvv-1.0: remove vmford.vv and vmford.vf frank.chang
2020-08-17 8:49 ` [RFC v4 60/70] target/riscv: rvv-1.0: remove integer extract instruction frank.chang
2020-08-17 8:49 ` [RFC v4 61/70] target/riscv: rvv-1.0: floating-point min/max instructions frank.chang
2020-08-29 23:58 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 62/70] target/riscv: introduce floating-point rounding mode enum frank.chang
2020-08-30 0:02 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 63/70] target/riscv: rvv-1.0: floating-point/integer type-convert instructions frank.chang
2020-08-30 0:06 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 64/70] target/riscv: rvv-1.0: widening floating-point/integer type-convert frank.chang
2020-08-30 0:14 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 65/70] target/riscv: add "set round to odd" rounding mode helper function frank.chang
2020-08-30 0:18 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 66/70] target/riscv: rvv-1.0: narrowing floating-point/integer type-convert frank.chang
2020-08-30 0:21 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 67/70] target/riscv: rvv-1.0: relax RV_VLEN_MAX to 512-bits frank.chang
2020-08-30 1:39 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 68/70] target/riscv: gdb: modify gdb csr xml file to align with csr register map frank.chang
2020-08-30 2:16 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 69/70] target/riscv: gdb: support vector registers for rv64 frank.chang
2020-08-30 1:57 ` Richard Henderson
2020-08-17 8:49 ` [RFC v4 70/70] target/riscv: gdb: support vector registers for rv32 frank.chang
2020-08-30 1:57 ` Richard Henderson
2020-08-25 8:28 ` [RFC v4 00/70] support vector extension v1.0 Frank Chang
2020-08-26 16:45 ` Alistair Francis
2020-08-26 17:39 ` Frank Chang
2020-08-26 17:52 ` Alistair Francis
2020-08-26 18:12 ` Frank Chang
2020-08-26 21:17 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30dcedd1-84e3-70c4-7b8b-d985608b81c5@linaro.org \
--to=richard.henderson@linaro.org \
--cc=Alistair.Francis@wdc.com \
--cc=frank.chang@sifive.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sagark@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).