From: "Cédric Le Goater" <clg@kaod.org>
To: Fabiano Rosas <farosas@linux.ibm.com>, <qemu-devel@nongnu.org>
Cc: danielhb413@gmail.com, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au
Subject: Re: [PATCH 5/5] target/ppc: books: Program exception cleanup
Date: Tue, 25 Jan 2022 13:11:53 +0100 [thread overview]
Message-ID: <30facc0c-a9c9-04b7-c220-d3755f87e176@kaod.org> (raw)
In-Reply-To: <20220124184605.999353-6-farosas@linux.ibm.com>
On 1/24/22 19:46, Fabiano Rosas wrote:
> Remove setting of BookE registers.
>
> Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks,
C.
> ---
> target/ppc/excp_helper.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index 67faec3775..d1cce76e75 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -688,20 +688,16 @@ static void powerpc_excp_books(PowerPCCPU *cpu, int excp)
> * precise in the MSR.
> */
> msr |= 0x00100000;
> - env->spr[SPR_BOOKE_ESR] = ESR_FP;
> break;
> case POWERPC_EXCP_INVAL:
> trace_ppc_excp_inval(env->nip);
> msr |= 0x00080000;
> - env->spr[SPR_BOOKE_ESR] = ESR_PIL;
> break;
> case POWERPC_EXCP_PRIV:
> msr |= 0x00040000;
> - env->spr[SPR_BOOKE_ESR] = ESR_PPR;
> break;
> case POWERPC_EXCP_TRAP:
> msr |= 0x00020000;
> - env->spr[SPR_BOOKE_ESR] = ESR_PTR;
> break;
> default:
> /* Should never occur */
>
next prev parent reply other threads:[~2022-01-25 12:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 18:46 [PATCH 0/5] target/ppc: powerpc_excp improvements [BookS] (4/n) Fabiano Rosas
2022-01-24 18:46 ` [PATCH 1/5] target/ppc: Introduce powerpc_excp_books Fabiano Rosas
2022-01-25 12:06 ` Cédric Le Goater
2022-01-24 18:46 ` [PATCH 2/5] target/ppc: Simplify powerpc_excp_books Fabiano Rosas
2022-01-25 12:09 ` Cédric Le Goater
2022-01-24 18:46 ` [PATCH 3/5] target/ppc: books: Machine Check exception cleanup Fabiano Rosas
2022-01-25 12:09 ` Cédric Le Goater
2022-01-24 18:46 ` [PATCH 4/5] target/ppc: books: External interrupt cleanup Fabiano Rosas
2022-01-25 12:11 ` Cédric Le Goater
2022-01-24 18:46 ` [PATCH 5/5] target/ppc: books: Program exception cleanup Fabiano Rosas
2022-01-25 12:11 ` Cédric Le Goater [this message]
2022-01-25 12:28 ` [PATCH 0/5] target/ppc: powerpc_excp improvements [BookS] (4/n) Cédric Le Goater
2022-01-25 14:54 ` Fabiano Rosas
2022-01-25 15:15 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30facc0c-a9c9-04b7-c220-d3755f87e176@kaod.org \
--to=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=farosas@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).