From: gaosong <gaosong@loongson.cn>
To: Tianrui Zhao <zhaotianrui@loongson.cn>, qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org, maobibo@loongson.cn,
yangxiaojuan@loongson.cn
Subject: Re: [PATCH v3] hw/loongarch: Add virtio-mmio bus support
Date: Thu, 14 Sep 2023 16:49:23 +0800 [thread overview]
Message-ID: <30fd65d6-930f-8a02-68fb-25d0ccded9db@loongson.cn> (raw)
In-Reply-To: <20230911085903.664996-1-zhaotianrui@loongson.cn>
在 2023/9/11 下午4:59, Tianrui Zhao 写道:
> +static void fdt_add_virtio_mmio_node(LoongArchMachineState *lams)
> +{
> + int i;
> + MachineState *ms = MACHINE(lams);
> +
> + for (i = VIRT_VIRTIO_MMIO_NUM - 1; i >= 0; i--) {
> + char *nodename;
> + hwaddr base = VIRT_VIRTIO_MMIO_BASE + i * VIRT_VIRTIO_MMIO_SIZE;
> +
> + nodename = g_strdup_printf("/virtio_mmio@%" PRIx64, base);
> + qemu_fdt_add_subnode(ms->fdt, nodename);
> + qemu_fdt_setprop_string(ms->fdt, nodename,
> + "compatible", "virtio,mmio");
> + qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg",
> + 2, base, 2, VIRT_VIRTIO_MMIO_SIZE);
Missing node interrupts.
Thanks.
Song Gao
> + g_free(nodename);
> + }
> +}
prev parent reply other threads:[~2023-09-14 8:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 8:59 [PATCH v3] hw/loongarch: Add virtio-mmio bus support Tianrui Zhao
2023-09-14 8:23 ` gaosong
2023-09-14 8:49 ` gaosong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30fd65d6-930f-8a02-68fb-25d0ccded9db@loongson.cn \
--to=gaosong@loongson.cn \
--cc=maobibo@loongson.cn \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=yangxiaojuan@loongson.cn \
--cc=zhaotianrui@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).