From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: laurent@vivier.eu, imp@bsdimp.com
Subject: Re: [PATCH v4 8/9] common-user: Adjust system call return on FreeBSD
Date: Wed, 17 Nov 2021 09:32:40 +0100 [thread overview]
Message-ID: <31127125-7e7e-ac1f-07f9-2f62df6c1f28@linaro.org> (raw)
In-Reply-To: <dddc2e78-27ae-dcb3-6f10-29f935fec9c4@amsat.org>
On 11/17/21 9:23 AM, Philippe Mathieu-Daudé wrote:
> On 11/16/21 12:02, Richard Henderson wrote:
>> From: Warner Losh <imp@bsdimp.com>
>>
>> FreeBSD system calls return positive errno. On the 4 hosts for
>> which we have support, error is indicated by the C bit set or clear.
>>
>> Signed-off-by: Warner Losh <imp@bsdimp.com>
>> [rth: Rebase on new safe_syscall_base api; add #error check.]
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>> common-user/host/aarch64/safe-syscall.inc.S | 12 +++++++++++-
>> common-user/host/arm/safe-syscall.inc.S | 11 +++++++++++
>
> Can we split this in 2 patches?
>
>> common-user/host/i386/safe-syscall.inc.S | 10 ++++++++++
>> common-user/host/x86_64/safe-syscall.inc.S | 10 ++++++++++
>> 4 files changed, 42 insertions(+), 1 deletion(-)
Why 2?
They're small enough that I think having them all together is fine, but otherwise why
wouldn't I split to 4?
r~
next prev parent reply other threads:[~2021-11-17 8:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 11:02 [PATCH v4 0/9] linux-user: simplify safe signal handling Richard Henderson
2021-11-16 11:02 ` [PATCH v4 1/9] linux-user: Add host_signal_set_pc to set pc in mcontext Richard Henderson
2021-11-16 11:02 ` [PATCH v4 2/9] linux-user/signal.c: Create a common rewind_if_in_safe_syscall Richard Henderson
2021-11-16 11:02 ` [PATCH v4 3/9] linux-user/safe-syscall.inc.S: Move to common-user Richard Henderson
2021-11-16 21:03 ` Warner Losh
2021-11-17 8:11 ` Philippe Mathieu-Daudé
2021-11-17 12:49 ` Richard Henderson
2021-11-17 16:09 ` Warner Losh
2021-11-17 16:20 ` Philippe Mathieu-Daudé
2021-11-16 11:02 ` [PATCH v4 4/9] common-user: Move syscall error detection into safe_syscall_base Richard Henderson
2021-11-16 11:02 ` [PATCH v4 5/9] common-user/host/mips: Add safe-syscall.inc.S Richard Henderson
2021-11-16 11:02 ` [PATCH v4 6/9] common-user/host/sparc64: " Richard Henderson
2021-11-16 11:02 ` [PATCH v4 7/9] linux-user: Remove HAVE_SAFE_SYSCALL and hostdep.h Richard Henderson
2021-11-17 8:22 ` Philippe Mathieu-Daudé
2021-11-17 15:58 ` Warner Losh
2021-11-16 11:02 ` [PATCH v4 8/9] common-user: Adjust system call return on FreeBSD Richard Henderson
2021-11-16 20:58 ` Warner Losh
2021-11-16 21:43 ` Richard Henderson
2021-11-17 8:23 ` Philippe Mathieu-Daudé
2021-11-17 8:32 ` Richard Henderson [this message]
2021-11-17 8:38 ` Philippe Mathieu-Daudé
2021-11-16 11:02 ` [PATCH v4 9/9] common-user: Move safe-syscall.* from *-user Richard Henderson
2021-11-16 21:10 ` [PATCH v4 0/9] linux-user: simplify safe signal handling Warner Losh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31127125-7e7e-ac1f-07f9-2f62df6c1f28@linaro.org \
--to=richard.henderson@linaro.org \
--cc=f4bug@amsat.org \
--cc=imp@bsdimp.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).