From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: Will Cohen <wwcohen@gmail.com>, Thomas Huth <thuth@redhat.com>,
Laurent Vivier <lvivier@redhat.com>, Greg Kurz <groug@kaod.org>,
hi@alyssa.is, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v3 11/11] 9p: darwin: adjust assumption on virtio-9p-test
Date: Fri, 28 Jan 2022 16:28:06 +0100 [thread overview]
Message-ID: <3125627.2FGSiGUHTB@silver> (raw)
In-Reply-To: <CAB26zV3ej+Bp1M0czmFPTgisdFKKwkOQwQfm+TorUtqyPAjsCw@mail.gmail.com>
On Freitag, 28. Januar 2022 14:38:43 CET Will Cohen wrote:
> Apologies! The explanation (and what I'll include in v4) is below:
>
> The previous test depended on the assumption that P9_DOTL_AT_REMOVEDIR and
> AT_REMOVEDIR have the same value.
>
> While this is true on Linux, it is not true everywhere, and leads to an
> incorrect test failure on unlink_at, noticed when adding 9p to darwin.
Additionally describing the observed misbehaviour is always useful.
Best regards,
Christian Schoenebeck
prev parent reply other threads:[~2022-01-28 15:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 0:56 [PATCH v3 00/11] This is a followup to https://lists.gnu.org/archive/html/qemu-devel/2021-11/msg04325.html, Will Cohen
2022-01-28 0:56 ` [PATCH v3 01/11] 9p: linux: Fix a couple Linux assumptions Will Cohen
2022-01-28 15:52 ` Greg Kurz
2022-01-28 0:56 ` [PATCH v3 02/11] 9p: Rename 9p-util -> 9p-util-linux Will Cohen
2022-01-28 16:27 ` Greg Kurz
2022-01-28 0:56 ` [PATCH v3 03/11] 9p: darwin: Handle struct stat(fs) differences Will Cohen
2022-02-02 17:48 ` Christian Schoenebeck
2022-01-28 0:56 ` [PATCH v3 04/11] 9p: darwin: Handle struct dirent differences Will Cohen
2022-02-02 15:07 ` Will Cohen
2022-02-02 17:37 ` Christian Schoenebeck
2022-02-02 18:31 ` Will Cohen
2022-01-28 0:56 ` [PATCH v3 05/11] 9p: darwin: Ignore O_{NOATIME, DIRECT} Will Cohen
2022-01-28 0:56 ` [PATCH v3 06/11] 9p: darwin: Compatibility defn for XATTR_SIZE_MAX Will Cohen
2022-01-28 16:02 ` Christian Schoenebeck
2022-01-28 0:56 ` [PATCH v3 07/11] 9p: darwin: *xattr_nofollow implementations Will Cohen
2022-01-28 0:56 ` [PATCH v3 08/11] 9p: darwin: Compatibility for f/l*xattr Will Cohen
2022-01-28 0:56 ` [PATCH v3 09/11] 9p: darwin: Implement compatibility for mknodat Will Cohen
2022-01-28 0:56 ` [PATCH v3 10/11] 9p: darwin: meson: Allow VirtFS on Darwin Will Cohen
2022-01-28 0:56 ` [PATCH v3 11/11] 9p: darwin: adjust assumption on virtio-9p-test Will Cohen
2022-01-28 7:03 ` Thomas Huth
2022-01-28 13:38 ` Will Cohen
2022-01-28 15:28 ` Christian Schoenebeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3125627.2FGSiGUHTB@silver \
--to=qemu_oss@crudebyte.com \
--cc=groug@kaod.org \
--cc=hi@alyssa.is \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wwcohen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).