From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: fam@euphon.net, Thomas Huth <thuth@redhat.com>,
berrange@redhat.com, David Hildenbrand <david@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
f4bug@amsat.org, Laurent Vivier <laurent@vivier.eu>,
"open list:S390 general arch..." <qemu-s390x@nongnu.org>,
stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com,
aurelien@aurel32.net
Subject: Re: [PATCH] target/s390x: fix s390_probe_access to check PAGE_WRITE_ORG for writeability
Date: Thu, 22 Apr 2021 09:10:55 -0700 [thread overview]
Message-ID: <31291766-f4f2-581d-2019-214d95d70158@linaro.org> (raw)
In-Reply-To: <20210422154427.13038-1-alex.bennee@linaro.org>
On 4/22/21 8:44 AM, Alex Bennée wrote:
> We can remove PAGE_WRITE when (internally) marking a page read-only
> because it contains translated code. This can get confused when we are
> executing signal return code on signal stacks.
>
> Fixes: e56552cf07 ("target/s390x: Implement the MVPG condition-code-option bit")
> Found-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Cornelia Huck <cohuck@redhat.com>
> Cc: Thomas Huth <thuth@redhat.com>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Laurent Vivier <laurent@vivier.eu>
> ---
> target/s390x/mem_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-04-22 16:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 15:44 [PATCH] target/s390x: fix s390_probe_access to check PAGE_WRITE_ORG for writeability Alex Bennée
2021-04-22 16:10 ` Richard Henderson [this message]
2021-04-22 16:43 ` David Hildenbrand
2021-04-23 12:22 ` Cornelia Huck
2021-04-23 13:06 ` Peter Maydell
2021-04-23 13:28 ` Thomas Huth
2021-04-23 13:52 ` Cornelia Huck
2021-04-23 13:56 ` Peter Maydell
2021-04-23 15:44 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31291766-f4f2-581d-2019-214d95d70158@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=cohuck@redhat.com \
--cc=crosa@redhat.com \
--cc=david@redhat.com \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).