From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B441C433B4 for ; Thu, 22 Apr 2021 16:14:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D130061406 for ; Thu, 22 Apr 2021 16:14:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D130061406 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZbyR-00052Z-L7 for qemu-devel@archiver.kernel.org; Thu, 22 Apr 2021 12:14:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50588) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZbuu-0002eC-Qd for qemu-devel@nongnu.org; Thu, 22 Apr 2021 12:11:00 -0400 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]:42726) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lZbus-0002YM-Rh for qemu-devel@nongnu.org; Thu, 22 Apr 2021 12:11:00 -0400 Received: by mail-pg1-x536.google.com with SMTP id m12so12450068pgr.9 for ; Thu, 22 Apr 2021 09:10:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jiPtMf3rIfzk76AcYG8rVQ61uCkSIHzCPNac6slFBrU=; b=Fx3whZH7v0kIEYvz6VJJkVJOWoen1Egb94AepiV+hsWpXU0AabGV5sslxn7/WqwoRQ 0GP735zCWPtyqWMI1Ukoisw3POX0Q3qiU70P03wFGmmEQlfo1qn8FJXWS0kuQK1F+EzO VesQQOLmQwCDN1uS103sEJJ4G2HQ1yfGJ9k6hDkgHafj/GFE4JEPtGQa/CYw/ulq9gpp GIwh0DrKfCugR2YnLkyR3H+5oAA/JFmQ/t9MidtMXA2k7/ZarK9crR/8ZVwxoB2b3m2Q NlM+YyMY9DpmtEfwRsMJxxiQSEui/B5qjJNuwn+mBhQQ/qz3+LlHx5RnA+rmAjDwZl9h NTwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jiPtMf3rIfzk76AcYG8rVQ61uCkSIHzCPNac6slFBrU=; b=kEKI47b/haxPs47I4g/5cJjS4z2nVKzH/+vzLFjBhwWETshR2+fQ6/fThQ+RHGoCmk OlMOE9DAhzBcdoO0hsFk3kuVPpWjRqkX7CM65WPQ/XvgWOPfaWyhUYK1F+bysRIPIT5o hQt+X9cCnM7NKXXxu1X1VhNlDau0yvUVJfKTz4nJk2dL4ULMeJWWKdPladL455VsfPsa RyvG/kcP0G/UyZPaHkDOYTVZa8+22YsVisKv17WTxutcYYG+iMz81trALO54s5yT8jdn QnpZ7WiC8sFN3h6VxHRZ6DizaLqeIq0AkjS6h+Foky7tfa5dUAADbDZqrOoyQoI4jl// 3o8A== X-Gm-Message-State: AOAM531H5ntQpn3zE+MFRf2ECvx3trNVoPHOBXvi8W/LFb27gmxAkSr/ gKa4iI+//DBpdD10dOtTWXrwlw== X-Google-Smtp-Source: ABdhPJzyKHxqUf6Tclw939/kcHe8WaA2AXvDAe4bAfagIZOF0l/zkL4n4XWMdBsUNmJRAYKmIWfoog== X-Received: by 2002:a05:6a00:c8:b029:260:f25a:f2ef with SMTP id e8-20020a056a0000c8b0290260f25af2efmr4115618pfj.78.1619107857184; Thu, 22 Apr 2021 09:10:57 -0700 (PDT) Received: from [192.168.1.11] ([71.212.131.83]) by smtp.gmail.com with ESMTPSA id n9sm2751065pgt.35.2021.04.22.09.10.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Apr 2021 09:10:56 -0700 (PDT) Subject: Re: [PATCH] target/s390x: fix s390_probe_access to check PAGE_WRITE_ORG for writeability To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org References: <20210422154427.13038-1-alex.bennee@linaro.org> From: Richard Henderson Message-ID: <31291766-f4f2-581d-2019-214d95d70158@linaro.org> Date: Thu, 22 Apr 2021 09:10:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210422154427.13038-1-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::536; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, Thomas Huth , berrange@redhat.com, David Hildenbrand , Cornelia Huck , f4bug@amsat.org, Laurent Vivier , "open list:S390 general arch..." , stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, aurelien@aurel32.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/22/21 8:44 AM, Alex Bennée wrote: > We can remove PAGE_WRITE when (internally) marking a page read-only > because it contains translated code. This can get confused when we are > executing signal return code on signal stacks. > > Fixes: e56552cf07 ("target/s390x: Implement the MVPG condition-code-option bit") > Found-by: Richard Henderson > Signed-off-by: Alex Bennée > Cc: Cornelia Huck > Cc: Thomas Huth > Cc: David Hildenbrand > Cc: Laurent Vivier > --- > target/s390x/mem_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~