From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org,
Jean-Christophe DUBOIS <jcd@tribudubois.net>
Subject: Re: [Qemu-devel] [PATCH for-2.7 0/3] Add memory_region_init_rom() and use to fix imx board crashes
Date: Tue, 28 Jun 2016 13:53:40 -0400 (EDT) [thread overview]
Message-ID: <312978165.2723879.1467136420274.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1467122287-24974-1-git-send-email-peter.maydell@linaro.org>
> We can then add an assert() in memory_region_init_rom_device()
> to prevent further misuse. (Passing NULL was documented as
> "I/O space is not supposed to be handled by QEMU itself", but this
> doesn't make much sense (who would be handling the writes?) and
> isn't used by any of the callers.)
>
> This is for-2.7 because it fixes a crash in the imx boards
> if the guest misbehaves:
> https://bugs.launchpad.net/qemu/+bug/1596160
Go ahead and include this in target-arm (and since we're at it,
it would be great if you handled Cedric's m25p80 series when he
sends out the rebase).
Paolo
next prev parent reply other threads:[~2016-06-28 17:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 13:58 [Qemu-devel] [PATCH for-2.7 0/3] Add memory_region_init_rom() and use to fix imx board crashes Peter Maydell
2016-06-28 13:58 ` [Qemu-devel] [PATCH for-2.7 1/3] memory: Provide memory_region_init_rom() Peter Maydell
2016-06-28 13:58 ` [Qemu-devel] [PATCH for-2.7 2/3] imx: Use memory_region_init_rom() for ROMs Peter Maydell
2016-06-28 13:58 ` [Qemu-devel] [PATCH for-2.7 3/3] memory: Assert that memory_region_init_rom_device() ops aren't NULL Peter Maydell
2016-06-28 17:53 ` Paolo Bonzini [this message]
2016-06-28 18:10 ` [Qemu-devel] [PATCH for-2.7 0/3] Add memory_region_init_rom() and use to fix imx board crashes Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=312978165.2723879.1467136420274.JavaMail.zimbra@redhat.com \
--to=pbonzini@redhat.com \
--cc=jcd@tribudubois.net \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).