From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHxCm-0008B8-1e for qemu-devel@nongnu.org; Tue, 28 Jun 2016 13:53:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHxCh-0007hZ-BV for qemu-devel@nongnu.org; Tue, 28 Jun 2016 13:53:48 -0400 Date: Tue, 28 Jun 2016 13:53:40 -0400 (EDT) From: Paolo Bonzini Message-ID: <312978165.2723879.1467136420274.JavaMail.zimbra@redhat.com> In-Reply-To: <1467122287-24974-1-git-send-email-peter.maydell@linaro.org> References: <1467122287-24974-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.7 0/3] Add memory_region_init_rom() and use to fix imx board crashes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org, Jean-Christophe DUBOIS > We can then add an assert() in memory_region_init_rom_device() > to prevent further misuse. (Passing NULL was documented as > "I/O space is not supposed to be handled by QEMU itself", but this > doesn't make much sense (who would be handling the writes?) and > isn't used by any of the callers.) > > This is for-2.7 because it fixes a crash in the imx boards > if the guest misbehaves: > https://bugs.launchpad.net/qemu/+bug/1596160 Go ahead and include this in target-arm (and since we're at it, it would be great if you handled Cedric's m25p80 series when he sends out the rebase). Paolo