From: ralf@humppa.name
To: qemu-devel@nongnu.org
Cc: ralf@humppa.name
Subject: [Qemu-devel] [PATCH] hw: improve multiboot module loading
Date: Thu, 7 Apr 2011 00:19:01 -0000 (UTC) [thread overview]
Message-ID: <312edea8efadfde52c4c6d267c924cf2.squirrel@humppa.name> (raw)
Multiboot modules couldn't be loaded when there are spaces between the
filename and ','. Those spaces can simply be killed.
Signed-off-by:
---
diff --git a/hw/multiboot.c b/hw/multiboot.c
index 0d2bfb4..27eb159 100644
--- a/hw/multiboot.c
+++ b/hw/multiboot.c
@@ -267,6 +267,9 @@ int load_multiboot(void *fw_cfg,
/* if a space comes after the module filename, treat everything
after that as parameters */
target_phys_addr_t c = mb_add_cmdline(&mbs, initrd_filename);
+ /* Kill spaces at the beginning of the filename */
+ while( *initrd_filename == ' ' )
+ initrd_filename++;
if ((next_space = strchr(initrd_filename, ' ')))
*next_space = '\0';
mb_debug("multiboot loading module: %s\n", initrd_filename);
next reply other threads:[~2011-04-07 0:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 0:19 ralf [this message]
2011-04-07 0:31 ` [Qemu-devel] [PATCH] hw: improve multiboot module loading Alexander Graf
2011-04-07 5:56 ` Ralf Ramsauer
2011-04-07 8:38 ` Alexander Graf
2011-04-07 12:07 ` Ralf Ramsauer
2011-04-07 12:15 ` Alexander Graf
2011-04-07 12:24 ` Ralf Ramsauer
2011-04-07 12:48 ` Stefan Hajnoczi
2011-04-07 12:56 ` Ralf Ramsauer
2011-04-07 13:52 ` Stefan Hajnoczi
2011-04-07 18:13 ` Adam Lackorzynski
2011-04-07 2:00 ` Brad Hards
2011-04-07 8:43 ` Stefan Hajnoczi
2011-04-07 10:18 ` Ralf Ramsauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=312edea8efadfde52c4c6d267c924cf2.squirrel@humppa.name \
--to=ralf@humppa.name \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).