From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lgln9-0007jc-N5
	for qemu-devel@nongnu.org; Mon, 09 Mar 2009 16:09:39 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lgln6-0007fP-Uq
	for qemu-devel@nongnu.org; Mon, 09 Mar 2009 16:09:38 -0400
Received: from [199.232.76.173] (port=36164 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lgln6-0007eo-2k
	for qemu-devel@nongnu.org; Mon, 09 Mar 2009 16:09:36 -0400
Received: from mx20.gnu.org ([199.232.41.8]:2653)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <revol@free.fr>) id 1Lgln5-00075Z-Pt
	for qemu-devel@nongnu.org; Mon, 09 Mar 2009 16:09:35 -0400
Received: from smtp1-g21.free.fr ([212.27.42.1])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <revol@free.fr>) id 1LggEj-0005NQ-La
	for qemu-devel@nongnu.org; Mon, 09 Mar 2009 10:13:46 -0400
In-Reply-To: <49B4D5FE.7050409@redhat.com>
Subject: Re: [HaikuPorts-devs] [Qemu-devel] Re: [PATCH] [RFC] Haiku host
	support and general configure issues
From: "=?utf-8?q?Fran=C3=A7ois?= Revol" <revol@free.fr>
Date: Mon, 09 Mar 2009 15:14:12 +0100 CET
Message-Id: <3165008770-BeMail@laptop>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: haikuports-devs@ports.haiku-files.org, qemu-devel@nongnu.org

> Anthony Liguori wrote:
> >>
> >>> Another big issue that I mentionned earlier here is the widely 
> > > > used
> >>> assumption that error codes are positive, which is not the case 
> > > > for
> >>> BeOS and Haiku.
> >>> Not fixing this will result in a dangerous binary.
> >>
> >> Thanks for the reminder. But that also reminds me, you wanted to 
> >> supply a patch for that! :)
> >
> > Such a patch may be something ya'll have to maintain on your own.  
> > This has been discussed a lot in the past and I'm concerned that 
> > it's 
> > going to be too invasive.
> 
> We could define a qemu=5Ferrno() which returns errno converted to 
> positive 
> numbers.  While it will touch a lot of places, I don't think it can 
> be 
> considered invasive.

I'm used to using the opposite, RETERR() returning always negative 
codes from either errno or E*, and it works quite well.

I don't see the point in making stuff positive to return them negated.

Besides, one of the error codes in BeOS & Haiku will certainly overflow 
on 32bit (B=5FNO=5FMEMORY =3D B=5FGENERAL=5FERROR=5FBASE =3D LONG=5FMIN).

Fran=C3=A7ois.