From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCO7f-0007vS-5o for qemu-devel@nongnu.org; Mon, 13 Jun 2016 05:25:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCO7a-0007Ap-KH for qemu-devel@nongnu.org; Mon, 13 Jun 2016 05:25:31 -0400 References: <1465808915-4887-1-git-send-email-vijayak@caviumnetworks.com> <1465808915-4887-5-git-send-email-vijayak@caviumnetworks.com> From: Paolo Bonzini Message-ID: <3182a047-21e2-cccf-b42f-bc1651c51f45@redhat.com> Date: Mon, 13 Jun 2016 11:25:14 +0200 MIME-Version: 1.0 In-Reply-To: <1465808915-4887-5-git-send-email-vijayak@caviumnetworks.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v1 4/4] target-arm: Compute page size based on ARM target cpu type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: vijayak@caviumnetworks.com, qemu-arm@nongnu.org, peter.maydell@linaro.org, quintela@redhat.com Cc: qemu-devel@nongnu.org, Prasun.Kapoor@caviumnetworks.com, vijay.kilari@gmail.com, Vijaya Kumar K , Vijaya Kumar K On 13/06/2016 11:08, vijayak@caviumnetworks.com wrote: > + */ > +#define TARGET_AARCH64_PAGE_BITS 12 > /* The ARM MMU allows 1k pages. */ > /* ??? Linux doesn't actually use these, and they're deprecated in recent > architecture revisions. Maybe a configure option to disable them. */ > -#define TARGET_PAGE_BITS 10 > -#endif > +#define TARGET_ARM_PAGE_BITS 10 > +#define TARGET_PAGE_BITS arm_get_target_page_bits() Please avoid the function call and just make it a variable target_page_bits. Paolo