From: Tim Wiederhake <twiederh@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 3/3] target/i386: Fix duplicated feature name in FEAT_KVM
Date: Fri, 25 Aug 2023 18:13:24 +0200 [thread overview]
Message-ID: <31cfbe193fe6638510d310f3e2a3de6c5365006a.camel@redhat.com> (raw)
In-Reply-To: <26d1e42b-3522-7a8a-1529-1067186e81d5@linaro.org>
On Thu, 2023-08-24 at 17:12 +0200, Philippe Mathieu-Daudé wrote:
> On 24/8/23 15:57, Tim Wiederhake wrote:
> > The mistake became apparent as there were two features with the
> > same name
> > in this cpuid leaf. The names are now in line with the
> > documentation from
> > https://kernel.org/doc/html/latest/virt/kvm/x86/cpuid.html
> >
>
> Fixes: 642258c6c7 ("kvm: add kvmclock to its second bit")
> ?
>
Right, added that locally. Thanks!
> > Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
> > ---
> > target/i386/cpu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> > index 0b74d80371..ceb291f8a8 100644
> > --- a/target/i386/cpu.c
> > +++ b/target/i386/cpu.c
> > @@ -852,7 +852,7 @@ FeatureWordInfo
> > feature_word_info[FEATURE_WORDS] = {
> > [FEAT_KVM] = {
> > .type = CPUID_FEATURE_WORD,
> > .feat_names = {
> > - "kvmclock", "kvm-nopiodelay", "kvm-mmu", "kvmclock",
> > + "kvmclock", "kvm-nopiodelay", "kvm-mmu", "kvmclock2",
> > "kvm-asyncpf", "kvm-steal-time", "kvm-pv-eoi", "kvm-
> > pv-unhalt",
> > NULL, "kvm-pv-tlb-flush", NULL, "kvm-pv-ipi",
> > "kvm-poll-control", "kvm-pv-sched-yield", "kvm-
> > asyncpf-int", "kvm-msi-ext-dest-id",
>
prev parent reply other threads:[~2023-08-25 16:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 13:57 [PATCH 0/3] Fix some feature names for i386 Tim Wiederhake
2023-08-24 13:57 ` [PATCH 1/3] target/i386: Add missing feature names in FEAT_VMX_EPT_VPID_CAPS Tim Wiederhake
2023-08-24 13:57 ` [PATCH 2/3] target/i386: Fix " Tim Wiederhake
2023-08-24 13:57 ` [PATCH 3/3] target/i386: Fix duplicated feature name in FEAT_KVM Tim Wiederhake
2023-08-24 15:12 ` Philippe Mathieu-Daudé
2023-08-25 16:13 ` Tim Wiederhake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31cfbe193fe6638510d310f3e2a3de6c5365006a.camel@redhat.com \
--to=twiederh@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).